Re: [Qemu-devel] [PATCH v4] usb/dev-hid: Modified usb-tablet category from Misc to Input

[Marcel Apfelbaum <marcel.a@redhat.com>]

On Sun, 2013-08-25 at 13:23 +0300, Michael S. Tsirkin wrote:
> On Thu, Aug 22, 2013 at 08:11:36PM +0300, Marcel Apfelbaum wrote:
> > usb-tablet device was wrongly assigned to Misc category
> > 
> > Reported-by: Markus Armbruster <armbru@redhat.com>
> > Cc: qemu-stable@nongnu.org
> > Signed-off-by: Marcel Apfelbaum <marcel.a@redhat.com>
> > Reviewed-by: Andreas Färber <afaerber@suse.de>
> 
> Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
pull? :)
Marcel

> 
> > ---
> > Changes from v3:
> >  - Added "Cc: qemu-stable@nongnu.org" this time in the sign-off area ...
> > Changes from v2:
> >  - Corrected spelling
> > Changes from v1:
> >  - Add cc to qemu-stable and Gerd Hoffmann
> >  - Changed subject prefix from hw to usb/dev-hid
> > 
> >  hw/usb/dev-hid.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/hw/usb/dev-hid.c b/hw/usb/dev-hid.c
> > index 66c6331..5956720 100644
> > --- a/hw/usb/dev-hid.c
> > +++ b/hw/usb/dev-hid.c
> > @@ -658,7 +658,7 @@ static void usb_tablet_class_initfn(ObjectClass *klass, void *data)
> >      uc->product_desc   = "QEMU USB Tablet";
> >      dc->vmsd = &vmstate_usb_ptr;
> >      dc->props = usb_tablet_properties;
> > -    set_bit(DEVICE_CATEGORY_MISC, dc->categories);
> > +    set_bit(DEVICE_CATEGORY_INPUT, dc->categories);
> >  }
> >  
> >  static const TypeInfo usb_tablet_info = {
> > -- 
> > 1.8.3.1