From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40411) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VEe58-00014k-Vx for qemu-devel@nongnu.org; Wed, 28 Aug 2013 07:38:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VEe52-0008Db-VG for qemu-devel@nongnu.org; Wed, 28 Aug 2013 07:38:38 -0400 Message-ID: <1377689906.20403.66.camel@nilsson.home.kraxel.org> From: Gerd Hoffmann Date: Wed, 28 Aug 2013 13:38:26 +0200 In-Reply-To: <20130828081050.GB17263@grmbl.mre> References: <1377673787.20403.16.camel@nilsson.home.kraxel.org> <20130828081050.GB17263@grmbl.mre> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/9] char: introduce tcp_chr_detach() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Amit Shah Cc: Paolo Bonzini , qemu-stable@nongnu.org, qemu list , Anthony Liguori , Hans de Goede > We don't need to worry about the listening socket for this patchset, > should we then just keep that in the tcp struct, and use the tag as > the generic one in CharDriverState for all of the backends? Yes, I think that will simplify the series. And maybe name the one one in CharDriverState 'fd_in_tag' to make more clear what it is. cheers, Gerd