qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: Gerd Hoffmann <kraxel@redhat.com>
Subject: [Qemu-devel] [PATCH 07/10] uas: add property for request logging
Date: Wed, 28 Aug 2013 14:43:03 +0200	[thread overview]
Message-ID: <1377693786-10844-9-git-send-email-kraxel@redhat.com> (raw)
In-Reply-To: <1377693786-10844-1-git-send-email-kraxel@redhat.com>

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 hw/usb/dev-uas.c | 15 ++++++++++++---
 1 file changed, 12 insertions(+), 3 deletions(-)

diff --git a/hw/usb/dev-uas.c b/hw/usb/dev-uas.c
index 63ad12e..8701292 100644
--- a/hw/usb/dev-uas.c
+++ b/hw/usb/dev-uas.c
@@ -113,6 +113,9 @@ struct UASDevice {
     QTAILQ_HEAD(, UASStatus)  results;
     QTAILQ_HEAD(, UASRequest) requests;
 
+    /* properties */
+    uint32_t                  requestlog;
+
     /* usb 2.0 only */
     USBPacket                 *status2;
     UASRequest                *datain2;
@@ -692,9 +695,9 @@ static void usb_uas_command(UASDevice *uas, uas_ui *ui)
     req->req = scsi_req_new(req->dev, req->tag,
                             usb_uas_get_lun(req->lun),
                             ui->command.cdb, req);
-#if 1
-    scsi_req_print(req->req);
-#endif
+    if (uas->requestlog) {
+        scsi_req_print(req->req);
+    }
     len = scsi_req_enqueue(req->req);
     if (len) {
         req->data_size = len;
@@ -902,6 +905,11 @@ static const VMStateDescription vmstate_usb_uas = {
     }
 };
 
+static Property uas_properties[] = {
+    DEFINE_PROP_UINT32("log-scsi-req", UASDevice, requestlog, 0),
+    DEFINE_PROP_END_OF_LIST(),
+};
+
 static void usb_uas_class_initfn(ObjectClass *klass, void *data)
 {
     DeviceClass *dc = DEVICE_CLASS(klass);
@@ -919,6 +927,7 @@ static void usb_uas_class_initfn(ObjectClass *klass, void *data)
     set_bit(DEVICE_CATEGORY_STORAGE, dc->categories);
     dc->fw_name = "storage";
     dc->vmsd = &vmstate_usb_uas;
+    dc->props = uas_properties;
 }
 
 static const TypeInfo uas_info = {
-- 
1.8.3.1

  parent reply	other threads:[~2013-08-28 12:44 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-28 12:42 [Qemu-devel] [PATCH 00/10] usb: a bunch of bugfixes Gerd Hoffmann
2013-08-28 12:42 ` [Qemu-devel] [PATCH 01/10] xhci: remove leftover debug printf Gerd Hoffmann
2013-08-28 12:42 ` [Qemu-devel] [PATCH 02/10] xhci: add tracepoint for endpoint state changes Gerd Hoffmann
2013-08-28 12:42 ` [Qemu-devel] [PATCH 03/10] xhci: add port to slot_address tracepoint Gerd Hoffmann
2013-08-28 12:43 ` [Qemu-devel] [PATCH 04/10] xhci: fix endpoint interval calculation Gerd Hoffmann
2013-08-28 12:43 ` [Qemu-devel] [PATCH 05/10] xhci: emulate intr endpoint intervals correctly Gerd Hoffmann
2013-09-25  0:55   ` Michael Roth
2013-09-25  6:27     ` Gerd Hoffmann
2013-08-28 12:43 ` [Qemu-devel] [PATCH 06/10] xhci: reset port when disabling slot Gerd Hoffmann
2013-08-28 12:43 ` Gerd Hoffmann [this message]
2013-08-28 12:43 ` [Qemu-devel] [PATCH 08/10] usb: parallelize usb3 streams Gerd Hoffmann
2013-08-28 12:43 ` [Qemu-devel] [PATCH 09/10] usb-hub: add tracepoint for status reports Gerd Hoffmann
2013-08-28 12:43 ` [Qemu-devel] [PATCH 10/10] Revert "usb-hub: report status changes only once" Gerd Hoffmann
2013-08-28 15:13   ` Hans de Goede
2013-08-28 15:30     ` Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1377693786-10844-9-git-send-email-kraxel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).