From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46401) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VFF8B-00089R-In for qemu-devel@nongnu.org; Thu, 29 Aug 2013 23:12:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VFF82-0006W8-36 for qemu-devel@nongnu.org; Thu, 29 Aug 2013 23:12:15 -0400 Received: from [222.73.24.84] (port=5164 helo=song.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VFF81-0006Uw-F9 for qemu-devel@nongnu.org; Thu, 29 Aug 2013 23:12:06 -0400 From: Wanlong Gao Date: Fri, 30 Aug 2013 11:10:47 +0800 Message-Id: <1377832250-1672-9-git-send-email-gaowanlong@cn.fujitsu.com> In-Reply-To: <1377832250-1672-1-git-send-email-gaowanlong@cn.fujitsu.com> References: <1377832250-1672-1-git-send-email-gaowanlong@cn.fujitsu.com> Subject: [Qemu-devel] [PATCH V11 08/11] NUMA: add qmp command set-mem-policy to set memory policy for NUMA node List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: aliguori@us.ibm.com, ehabkost@redhat.com, lersek@redhat.com, peter.huangpeng@huawei.com, lcapitulino@redhat.com, drjones@redhat.com, bsd@redhat.com, hutao@cn.fujitsu.com, y-goto@jp.fujitsu.com, pbonzini@redhat.com, afaerber@suse.de, gaowanlong@cn.fujitsu.com This QMP command allows user set guest node's memory policy through the QMP protocol. The qmp-shell command is like: set-mem-policy nodeid=0 policy=membind relative=true host-nodes=0-1 Signed-off-by: Wanlong Gao --- numa.c | 62 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++ qapi-schema.json | 21 +++++++++++++++++++ qmp-commands.hx | 41 +++++++++++++++++++++++++++++++++++++ 3 files changed, 124 insertions(+) diff --git a/numa.c b/numa.c index 89be03d..b911ffb 100644 --- a/numa.c +++ b/numa.c @@ -29,6 +29,7 @@ #include "qapi/opts-visitor.h" #include "qapi/dealloc-visitor.h" #include "exec/memory.h" +#include "qmp-commands.h" #ifdef __linux__ #include @@ -317,3 +318,64 @@ void set_numa_modes(void) } } } + +void qmp_set_mem_policy(uint16_t nodeid, bool has_policy, NumaNodePolicy policy, + bool has_relative, bool relative, + bool has_host_nodes, uint16List *host_nodes, + Error **errp) +{ + NumaNodePolicy old_policy; + bool old_relative; + DECLARE_BITMAP(host_mem, MAX_NODES); + uint16List *nodes; + + if (nodeid >= nb_numa_nodes) { + error_setg(errp, "Only has '%d' NUMA nodes", nb_numa_nodes); + return; + } + + bitmap_copy(host_mem, numa_info[nodeid].host_mem, MAX_NODES); + old_policy = numa_info[nodeid].policy; + old_relative = numa_info[nodeid].relative; + + numa_info[nodeid].policy = NUMA_NODE_POLICY_DEFAULT; + numa_info[nodeid].relative = false; + bitmap_zero(numa_info[nodeid].host_mem, MAX_NODES); + + if (!has_policy) { + if (set_node_mem_policy(nodeid) == -1) { + error_setg(errp, "Failed to set memory policy for node%" PRIu16, + nodeid); + goto error; + } + return; + } + + numa_info[nodeid].policy = policy; + + if (has_relative) { + numa_info[nodeid].relative = relative; + } + + if (!has_host_nodes) { + bitmap_fill(numa_info[nodeid].host_mem, MAX_NODES); + } + + for (nodes = host_nodes; nodes; nodes = nodes->next) { + bitmap_set(numa_info[nodeid].host_mem, nodes->value, 1); + } + + if (set_node_mem_policy(nodeid) == -1) { + error_setg(errp, "Failed to set memory policy for node%" PRIu16, + nodeid); + goto error; + } + + return; + +error: + bitmap_copy(numa_info[nodeid].host_mem, host_mem, MAX_NODES); + numa_info[nodeid].policy = old_policy; + numa_info[nodeid].relative = old_relative; + return; +} diff --git a/qapi-schema.json b/qapi-schema.json index 2160130..5e04b58 100644 --- a/qapi-schema.json +++ b/qapi-schema.json @@ -3849,3 +3849,24 @@ '*policy': 'NumaNodePolicy', '*relative': 'bool', '*host-nodes': ['uint16'] }} + +## +# @set-mem-policy: +# +# Set the host memory binding policy for guest NUMA node. +# +# @nodeid: The node ID of guest NUMA node to set memory policy to. +# +# @policy: #optional The memory policy to be set (default 'default'). +# +# @relative: #optional If the specified nodes are relative (default 'false') +# +# @host-nodes: #optional The host nodes range for memory policy. +# +# Returns: Nothing on success +# +# Since: 1.7 +## +{ 'command': 'set-mem-policy', + 'data': {'nodeid': 'uint16', '*policy': 'NumaNodePolicy', + '*relative': 'bool', '*host-nodes': ['uint16'] } } diff --git a/qmp-commands.hx b/qmp-commands.hx index cf47e3f..52e6ff3 100644 --- a/qmp-commands.hx +++ b/qmp-commands.hx @@ -3061,6 +3061,7 @@ Example: <- { "return": {} } EQMP + { .name = "query-rx-filter", .args_type = "name:s?", @@ -3124,3 +3125,43 @@ Example: } EQMP + + { + .name = "set-mem-policy", + .args_type = "nodeid:i,policy:s?,relative:b?,host-nodes:q?", + .help = "Set the host memory binding policy for guest NUMA node", + .mhandler.cmd_new = qmp_marshal_input_set_mem_policy, + }, + +SQMP +set-mem-policy +------ + +Set the host memory binding policy for guest NUMA node + +Arguments: + +- "nodeid": The nodeid of guest NUMA node to set memory policy to. + (json-int) +- "policy": The memory policy to set. + (json-string, optional) +- "relative": If the specified nodes are relative. + (json-bool, optional) +- "host-nodes": The host nodes contained to this memory policy. + (a json-array of int, optional) + +Example: + +-> { "execute": "set-mem-policy", "arguments": { "nodeid": 0, + "policy": "membind", + "relative": true, + "host-nodes": [0, 1] } } +<- { "return": {} } + +Notes: + 1. If "policy" is not set, the memory policy of this "nodeid" will be set + to "default". + 2. If "host-nodes" is not set, the node mask of this "policy" will be set + to all available host nodes. + +EQMP -- 1.8.4