From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48401) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VFPjA-00089g-89 for qemu-devel@nongnu.org; Fri, 30 Aug 2013 10:31:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VFPj2-0002f1-Oc for qemu-devel@nongnu.org; Fri, 30 Aug 2013 10:31:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47542) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VFPj2-0002ej-E2 for qemu-devel@nongnu.org; Fri, 30 Aug 2013 10:31:00 -0400 From: Kevin Wolf Date: Fri, 30 Aug 2013 16:30:27 +0200 Message-Id: <1377873051-18981-3-git-send-email-kwolf@redhat.com> In-Reply-To: <1377873051-18981-1-git-send-email-kwolf@redhat.com> References: <1377873051-18981-1-git-send-email-kwolf@redhat.com> Subject: [Qemu-devel] [PULL 02/26] block: Remove redundant assertion List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: anthony@codemonkey.ws Cc: kwolf@redhat.com, qemu-devel@nongnu.org The failing condition is checked immediately before the assertion, so keeping the assertion is kind of redundant. Signed-off-by: Kevin Wolf --- block.c | 1 - 1 file changed, 1 deletion(-) diff --git a/block.c b/block.c index a387c1a..26639e8 100644 --- a/block.c +++ b/block.c @@ -743,7 +743,6 @@ static int bdrv_open_common(BlockDriverState *bs, BlockDriverState *file, ret = -EINVAL; goto free_and_fail; } - assert(file != NULL); bs->file = file; ret = drv->bdrv_open(bs, options, open_flags); } -- 1.8.1.4