From: "Benoît Canet" <benoit@irqsave.net>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, stefanha@gmail.com,
"Benoît Canet" <benoit@irqsave.net>,
stefanha@redhat.com, pbonzini@redhat.com
Subject: [Qemu-devel] [PATCH V8 0/5] Continuous Leaky Bucket Throttling
Date: Fri, 30 Aug 2013 16:36:24 +0200 [thread overview]
Message-ID: <1377873389-9712-1-git-send-email-benoit@irqsave.net> (raw)
This patchset implement continous leaky bucket throttling.
It use two requests queue to enable to do silly unbalanced throttling like
block_set_io_throttle 0 0 0 0 6000 1
It use two timer to get the timer callbacks and the throttle.c code simple
in this version:
rearm timer only when it's not pending [Stefan]
Schedule next request right after accouting it [Stefan]
v7:
honor max values if specified [Paolo]
s/cfg/Linux CFQ/ [Stefan]
revert throttle_get_config to it's old prototype [Stefan]
s/size/@size/ [Stefan]
s/acccount/account/ [Stefan]
remove tracked_request_end uneeded hunk [Stefan]
Spaces before (json-int)s [Stefan]
v5-V6:
Rebased on top of Stefan's block branch.
switch to new timer API [Benoît]
s/timerstamp/timestamp/g [Fam]
Use QEMUTimerCB [Fam]
qemu_get_config return reference [Fam]
rename throttle_allowed to throttle_schedule_timer [Fam]
remove now parameter from throttle_compute_wait_for [Fam]
rename next_timer to next_timestamp [Fam]
rename ups to avg [Paolo]
let the enum numbering to the work [Paolo]
merge BUCKET_COUNT in the enum [Paolo]
rename bucket to level [Benoît/Stefan]
THROTTLING_H -> THROTTLE_H [Stefan]
use BUCKETS_COUNT in array declaration [Stefan]
remove unit_size [Stefan]
s/delta/delta_ns/g [Stefan]
remove qemu_timer_pending checks [Stefan]
explain magic [Stefan]
s/make/makes/ [Fam]
s/executed/executed,/[Fam]
s/bdrv_drain_throttled/bdrv_start_throttled_reqs/ [Stefan]
assert(!bs->io_limits enabled); [Stefan]
move outside tracked_request_begin/end [Stefan]
s/bycket/bucket/ [Stefan]
s/algoritm/algorithm/ [Stefan]
s/QMP/HMP/ [Stefan]
add missing space [Stefan]
Add \n in qemu-options.hx [Benoît]
rename iops_sector_count to iops_size [Stefan]
V4-V5
Fix bdrv_drain_all broken logic hence fixing the assertion error at exit.
v3-V4:
wrap qemu-option.hx declararation [Eric]
continuus -> continuous [Fam]
unit test [Paolo]
Benoît Canet (5):
throttle: Add a new throttling API implementing continuous leaky
bucket.
throttle: Add units tests
block: Enable the new throttling code in the block layer.
block: Add support for throttling burst max in QMP and the command
line.
block: Add iops_size to do the iops accounting for a given io size.
block.c | 338 +++++++++----------------------
block/qapi.c | 50 +++--
blockdev.c | 205 ++++++++++++++-----
hmp.c | 36 +++-
include/block/block.h | 1 -
include/block/block_int.h | 32 +--
include/qemu/throttle.h | 103 ++++++++++
qapi-schema.json | 40 +++-
qemu-options.hx | 4 +-
qmp-commands.hx | 34 +++-
tests/Makefile | 2 +
tests/test-throttle.c | 481 +++++++++++++++++++++++++++++++++++++++++++++
util/Makefile.objs | 1 +
util/throttle.c | 396 +++++++++++++++++++++++++++++++++++++
14 files changed, 1384 insertions(+), 339 deletions(-)
create mode 100644 include/qemu/throttle.h
create mode 100644 tests/test-throttle.c
create mode 100644 util/throttle.c
--
1.7.10.4
next reply other threads:[~2013-08-30 14:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-30 14:36 Benoît Canet [this message]
2013-08-30 14:36 ` [Qemu-devel] [PATCH V8 1/5] throttle: Add a new throttling API implementing continuous leaky bucket Benoît Canet
2013-08-30 14:36 ` [Qemu-devel] [PATCH V8 2/5] throttle: Add units tests Benoît Canet
2013-08-30 14:36 ` [Qemu-devel] [PATCH V8 3/5] block: Enable the new throttling code in the block layer Benoît Canet
2013-08-30 14:36 ` [Qemu-devel] [PATCH V8 4/5] block: Add support for throttling burst max in QMP and the command line Benoît Canet
2013-08-30 20:21 ` Eric Blake
2013-08-30 20:37 ` Benoît Canet
2013-08-30 20:39 ` Eric Blake
2013-08-30 20:56 ` Benoît Canet
2013-08-30 14:36 ` [Qemu-devel] [PATCH V8 5/5] block: Add iops_size to do the iops accounting for a given io size Benoît Canet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1377873389-9712-1-git-send-email-benoit@irqsave.net \
--to=benoit@irqsave.net \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).