From: "Andreas Färber" <afaerber@suse.de>
To: qemu-devel@nongnu.org
Cc: "Andreas Färber" <afaerber@suse.de>
Subject: [Qemu-devel] [PULL 05/17] ipack: Pass size to ipack_bus_new_inplace()
Date: Fri, 30 Aug 2013 21:29:31 +0200 [thread overview]
Message-ID: <1377890983-6481-6-git-send-email-afaerber@suse.de> (raw)
In-Reply-To: <1377890983-6481-1-git-send-email-afaerber@suse.de>
To be passed to qbus_create_inplace().
Simplify DEVICE() cast to avoid parent field access.
Reviewed-by: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
Signed-off-by: Andreas Färber <afaerber@suse.de>
---
hw/char/ipack.c | 3 ++-
hw/char/ipack.h | 3 ++-
hw/char/tpci200.c | 2 +-
3 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/hw/char/ipack.c b/hw/char/ipack.c
index f890471..5fb7073 100644
--- a/hw/char/ipack.c
+++ b/hw/char/ipack.c
@@ -24,7 +24,8 @@ IPackDevice *ipack_device_find(IPackBus *bus, int32_t slot)
return NULL;
}
-void ipack_bus_new_inplace(IPackBus *bus, DeviceState *parent,
+void ipack_bus_new_inplace(IPackBus *bus, size_t bus_size,
+ DeviceState *parent,
const char *name, uint8_t n_slots,
qemu_irq_handler handler)
{
diff --git a/hw/char/ipack.h b/hw/char/ipack.h
index f2b7a12..f8dc0f2 100644
--- a/hw/char/ipack.h
+++ b/hw/char/ipack.h
@@ -72,7 +72,8 @@ extern const VMStateDescription vmstate_ipack_device;
VMSTATE_STRUCT(_field, _state, 1, vmstate_ipack_device, IPackDevice)
IPackDevice *ipack_device_find(IPackBus *bus, int32_t slot);
-void ipack_bus_new_inplace(IPackBus *bus, DeviceState *parent,
+void ipack_bus_new_inplace(IPackBus *bus, size_t bus_size,
+ DeviceState *parent,
const char *name, uint8_t n_slots,
qemu_irq_handler handler);
diff --git a/hw/char/tpci200.c b/hw/char/tpci200.c
index d9e17b2..e04ff26 100644
--- a/hw/char/tpci200.c
+++ b/hw/char/tpci200.c
@@ -607,7 +607,7 @@ static int tpci200_initfn(PCIDevice *pci_dev)
pci_register_bar(&s->dev, 4, PCI_BASE_ADDRESS_SPACE_MEMORY, &s->las2);
pci_register_bar(&s->dev, 5, PCI_BASE_ADDRESS_SPACE_MEMORY, &s->las3);
- ipack_bus_new_inplace(&s->bus, DEVICE(&s->dev), NULL,
+ ipack_bus_new_inplace(&s->bus, sizeof(s->bus), DEVICE(pci_dev), NULL,
N_MODULES, tpci200_set_irq);
return 0;
--
1.8.1.4
next prev parent reply other threads:[~2013-08-30 19:30 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-30 19:29 [Qemu-devel] [PULL 00/17] QOM devices patch queue 2013-08-30 Andreas Färber
2013-08-30 19:29 ` [Qemu-devel] [PULL 01/17] object: Fix typo in qom/object.h Andreas Färber
2013-08-30 19:29 ` [Qemu-devel] [PULL 02/17] virtio: Remove unnecessary OBJECT() casts Andreas Färber
2013-08-30 19:29 ` [Qemu-devel] [PULL 03/17] qom: Fix object_initialize_with_type() argument name in documentation Andreas Färber
2013-08-30 19:29 ` [Qemu-devel] [PULL 04/17] intel-hda: Pass size to hda_codec_bus_init() Andreas Färber
2013-08-30 19:29 ` Andreas Färber [this message]
2013-08-30 19:29 ` [Qemu-devel] [PULL 06/17] ide: Pass size to ide_bus_new() Andreas Färber
2013-08-30 19:29 ` [Qemu-devel] [PULL 07/17] pci: Pass size to pci_bus_new_inplace() Andreas Färber
2013-08-30 19:29 ` [Qemu-devel] [PULL 08/17] scsi: Pass size to scsi_bus_new() Andreas Färber
2013-08-30 19:29 ` [Qemu-devel] [PULL 09/17] usb: Pass size to usb_bus_new() Andreas Färber
2013-08-30 19:29 ` [Qemu-devel] [PULL 10/17] virtio-pci: Pass size to virtio_pci_bus_new() Andreas Färber
2013-08-30 19:29 ` [Qemu-devel] [PULL 11/17] s390-virtio-bus: Pass size to virtio_s390_bus_new() Andreas Färber
2013-08-30 19:29 ` [Qemu-devel] [PULL 12/17] virtio-ccw: Pass size to virtio_ccw_bus_new() Andreas Färber
2013-08-30 19:29 ` [Qemu-devel] [PULL 13/17] virtio-mmio: Pass size to virtio_mmio_bus_new() Andreas Färber
2013-08-30 19:29 ` [Qemu-devel] [PULL 14/17] qdev: Pass size to qbus_create_inplace() Andreas Färber
2013-08-30 19:29 ` [Qemu-devel] [PULL 15/17] qom: Pass available size to object_initialize() Andreas Färber
2013-08-30 19:29 ` [Qemu-devel] [PULL 16/17] qom: Assert instance size in object_initialize_with_type() Andreas Färber
2013-08-30 19:29 ` [Qemu-devel] [PULL 17/17] isa: Fix documentation of isa_register_portio_list() Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1377890983-6481-6-git-send-email-afaerber@suse.de \
--to=afaerber@suse.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).