* [Qemu-devel] [PATCH] qmp: fix integer usage in examples
@ 2013-08-30 19:35 Eric Blake
2013-08-30 20:14 ` Benoît Canet
0 siblings, 1 reply; 2+ messages in thread
From: Eric Blake @ 2013-08-30 19:35 UTC (permalink / raw)
To: qemu-devel, qemu-trivial; +Cc: benoit, lcapitulino
* qmp-commands.hx (block_set_io_throttle): Use correct type.
Signed-off-by: Eric Blake <eblake@redhat.com>
---
Noticed while reviewing Benoît's series of "Continuous Leaky Bucket
Throttling" - depending on whose patch goes in first, the other
will have to rebase...
qmp-commands.hx | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/qmp-commands.hx b/qmp-commands.hx
index bb09e72..87cfdce 100644
--- a/qmp-commands.hx
+++ b/qmp-commands.hx
@@ -1412,12 +1412,12 @@ Arguments:
Example:
-> { "execute": "block_set_io_throttle", "arguments": { "device": "virtio0",
- "bps": "1000000",
- "bps_rd": "0",
- "bps_wr": "0",
- "iops": "0",
- "iops_rd": "0",
- "iops_wr": "0" } }
+ "bps": 1000000,
+ "bps_rd": 0,
+ "bps_wr": 0,
+ "iops": 0,
+ "iops_rd": 0,
+ "iops_wr": 0 } }
<- { "return": {} }
EQMP
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] qmp: fix integer usage in examples
2013-08-30 19:35 [Qemu-devel] [PATCH] qmp: fix integer usage in examples Eric Blake
@ 2013-08-30 20:14 ` Benoît Canet
0 siblings, 0 replies; 2+ messages in thread
From: Benoît Canet @ 2013-08-30 20:14 UTC (permalink / raw)
To: Eric Blake; +Cc: qemu-trivial, qemu-devel, lcapitulino
Le Friday 30 Aug 2013 à 13:35:53 (-0600), Eric Blake a écrit :
> * qmp-commands.hx (block_set_io_throttle): Use correct type.
>
> Signed-off-by: Eric Blake <eblake@redhat.com>
> ---
>
> Noticed while reviewing Benoît's series of "Continuous Leaky Bucket
> Throttling" - depending on whose patch goes in first, the other
> will have to rebase...
>
> qmp-commands.hx | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/qmp-commands.hx b/qmp-commands.hx
> index bb09e72..87cfdce 100644
> --- a/qmp-commands.hx
> +++ b/qmp-commands.hx
> @@ -1412,12 +1412,12 @@ Arguments:
> Example:
>
> -> { "execute": "block_set_io_throttle", "arguments": { "device": "virtio0",
> - "bps": "1000000",
> - "bps_rd": "0",
> - "bps_wr": "0",
> - "iops": "0",
> - "iops_rd": "0",
> - "iops_wr": "0" } }
> + "bps": 1000000,
> + "bps_rd": 0,
> + "bps_wr": 0,
> + "iops": 0,
> + "iops_rd": 0,
> + "iops_wr": 0 } }
> <- { "return": {} }
>
> EQMP
> --
> 1.8.3.1
>
I rebased my series on top of Eric patch.
Best regards
Benoît
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-08-30 20:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-30 19:35 [Qemu-devel] [PATCH] qmp: fix integer usage in examples Eric Blake
2013-08-30 20:14 ` Benoît Canet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).