From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43960)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benh@kernel.crashing.org>) id 1VFX3I-0007Hf-96
	for qemu-devel@nongnu.org; Fri, 30 Aug 2013 18:20:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <benh@kernel.crashing.org>) id 1VFX3C-0002Gh-02
	for qemu-devel@nongnu.org; Fri, 30 Aug 2013 18:20:24 -0400
Message-ID: <1377901187.3978.6.camel@pasglop>
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: Sat, 31 Aug 2013 08:19:47 +1000
In-Reply-To: <9C0990B9-FFE9-4FC7-83E6-7BD754F2E540@suse.de>
References: <1376891726-26122-1-git-send-email-aik@ozlabs.ru>
	<1376891726-26122-2-git-send-email-aik@ozlabs.ru>
	<5B9725EC-8FC8-469C-8758-08EED7D4206D@suse.de>
	<1377564201.3819.87.camel@pasglop> <521C0567.7070400@suse.de>
	<1377576606.3819.100.camel@pasglop>
	<315B31BA-FE61-45CA-A1C1-F1E67702E5F4@suse.de>
	<521F03EC.80908@ozlabs.ru>
	<9C0990B9-FFE9-4FC7-83E6-7BD754F2E540@suse.de>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 1/8] target-ppc: Add helper for
 KVM_PPC_RTAS_DEFINE_TOKEN
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: Alexey Kardashevskiy <aik@ozlabs.ru>, qemu-devel@nongnu.org, qemu-ppc@nongnu.org, Anthony Liguori <anthony@codemonkey.ws>, Paul Mackerras <paulus@samba.org>, Andreas =?ISO-8859-1?Q?F=E4rber?= <afaerber@suse.de>, David Gibson <david@gibson.dropbear.id.au>

On Fri, 2013-08-30 at 16:34 +0200, Alexander Graf wrote:

> > So - kvmppc_define_rtas_in_kernel() or kvmppc_define_rtas_kernel_token()?
> 
> The former probably.

I told him the latter :-) Honestly, your name is gross :-) Mine
describes exactly what the calls does.

> > I would actually though that the very first "k" is for "Kernel" already but...
> 
> I a symmetric API you could also remove rtas handling from the kernel, so you could tell the kernel "handle this in kernel space" and "don't handle this in kernel space". Our naming needs to be precise enough that you can guess what is going on from it.

But that's not quite what the API is doing and we don't want a symetric
API it's pointless.

Yet another "my CS teacher told me a good API is symetric" (oh and
that's a nice word "symetric", it sounds *good*, using it makes it
look like we are plenty smart !) but in the end totally pointless
for the problem at hand.

Ben.