From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55556) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VFdrW-0004Y3-3B for qemu-devel@nongnu.org; Sat, 31 Aug 2013 01:36:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VFdrR-0007Xu-Lh for qemu-devel@nongnu.org; Sat, 31 Aug 2013 01:36:42 -0400 Received: from mail-lb0-x235.google.com ([2a00:1450:4010:c04::235]:45427) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VFdrR-0007Xp-DP for qemu-devel@nongnu.org; Sat, 31 Aug 2013 01:36:37 -0400 Received: by mail-lb0-f181.google.com with SMTP id u14so2460170lbd.26 for ; Fri, 30 Aug 2013 22:36:36 -0700 (PDT) From: Antony Pavlov Date: Sat, 31 Aug 2013 09:33:56 +0400 Message-Id: <1377927237-6092-2-git-send-email-antonynpavlov@gmail.com> In-Reply-To: <1377927237-6092-1-git-send-email-antonynpavlov@gmail.com> References: <1377927237-6092-1-git-send-email-antonynpavlov@gmail.com> Subject: [Qemu-devel] [PATCH 1/2] milkymist-uart: use qemu_chr_fe_write_all() instead of qemu_chr_fe_write() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Anthony Liguori , Michael Walle , Peter Crosthwaite , Antony Pavlov Here is a quote from the qemu-devel maillist: qemu_chr_fe_write() is capable of returning 0 to indicate EAGAIN (and friends) and you don't handle this. Just change it to qemu_chr_fe_write_all() to fix. Signed-off-by: Antony Pavlov CC: Peter Crosthwaite CC: Michael Walle --- hw/char/milkymist-uart.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/char/milkymist-uart.c b/hw/char/milkymist-uart.c index 2e4b5c5..6e4bc20 100644 --- a/hw/char/milkymist-uart.c +++ b/hw/char/milkymist-uart.c @@ -124,7 +124,7 @@ static void uart_write(void *opaque, hwaddr addr, uint64_t value, switch (addr) { case R_RXTX: if (s->chr) { - qemu_chr_fe_write(s->chr, &ch, 1); + qemu_chr_fe_write_all(s->chr, &ch, 1); } s->regs[R_STAT] |= STAT_TX_EVT; break; -- 1.8.4.rc3