From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org
Cc: qemu-stable@nongnu.org, Anthony Liguori <anthony@codemonkey.ws>
Subject: [Qemu-devel] [PULL 6/6] virtio_pci: fix level interrupts with irqfd
Date: Mon, 2 Sep 2013 11:07:32 +0300 [thread overview]
Message-ID: <1378023590-11109-7-git-send-email-mst@redhat.com> (raw)
In-Reply-To: <1378023590-11109-1-git-send-email-mst@redhat.com>
commit 62c96360ae7f2c7a8b029277fbb7cb082fdef7fd
virtio-pci: fix level interrupts
only helps systems without irqfd: on systems with irqfd support we
passed in flag requesting irqfd even when msix is disabled.
As a result, for level interrupts we didn't install an fd handler so
unmasking an fd had no effect.
Fix this up.
Cc: qemu-stable@nongnu.org
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
hw/virtio/virtio-pci.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c
index d37037e..41b96ce 100644
--- a/hw/virtio/virtio-pci.c
+++ b/hw/virtio/virtio-pci.c
@@ -799,8 +799,7 @@ static int virtio_pci_set_guest_notifiers(DeviceState *d, int nvqs, bool assign)
break;
}
- r = virtio_pci_set_guest_notifier(d, n, assign,
- kvm_msi_via_irqfd_enabled());
+ r = virtio_pci_set_guest_notifier(d, n, assign, with_irqfd);
if (r < 0) {
goto assign_error;
}
--
MST
prev parent reply other threads:[~2013-09-02 8:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-02 8:07 [Qemu-devel] [PULL 0/6] pc,pci,virtio fixes and cleanups Michael S. Tsirkin
2013-09-02 8:07 ` [Qemu-devel] [PULL 1/6] pci: Introduce helper to retrieve a PCI device's DMA address space Michael S. Tsirkin
2013-09-02 8:07 ` [Qemu-devel] [PULL 2/6] pc: fix regression for 64 bit PCI memory Michael S. Tsirkin
2013-09-02 8:07 ` [Qemu-devel] [PULL 3/6] pci: add config space access traces Michael S. Tsirkin
2013-09-02 8:07 ` [Qemu-devel] [PULL 4/6] hw: Clean up bogus default boot order Michael S. Tsirkin
2013-09-02 8:07 ` [Qemu-devel] [PULL 5/6] pc: reduce duplication, fix PIIX descriptions Michael S. Tsirkin
2013-09-02 8:07 ` Michael S. Tsirkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1378023590-11109-7-git-send-email-mst@redhat.com \
--to=mst@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).