qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <rth@twiddle.net>
To: qemu-devel@nongnu.org
Cc: "Vassili Karpov (malc)" <av1474@comtv.ru>,
	aurelien@aurel32.net, Richard Henderson <rth@twiddle.net>
Subject: [Qemu-devel] [PATCH 02/14] tcg-ppc64: More use of TAI and SAI helper macros
Date: Sun,  1 Sep 2013 09:16:01 -0700	[thread overview]
Message-ID: <1378052173-3579-3-git-send-email-rth@twiddle.net> (raw)
In-Reply-To: <1378052173-3579-1-git-send-email-rth@twiddle.net>

Finish conversion of all memory operations.

Signed-off-by: Richard Henderson <rth@twiddle.net>
---
 tcg/ppc64/tcg-target.c | 41 ++++++++++++++++-------------------------
 1 file changed, 16 insertions(+), 25 deletions(-)

diff --git a/tcg/ppc64/tcg-target.c b/tcg/ppc64/tcg-target.c
index c0acaed..78acf3c 100644
--- a/tcg/ppc64/tcg-target.c
+++ b/tcg/ppc64/tcg-target.c
@@ -718,10 +718,10 @@ static void tcg_out_call(TCGContext *s, tcg_target_long arg, int const_arg)
         tcg_out_movi(s, TCG_TYPE_I64, reg, arg);
     }
 
-    tcg_out32(s, LD | RT(0) | RA(reg));
+    tcg_out32(s, LD | TAI(0, reg, 0));
     tcg_out32(s, MTSPR | RA(0) | CTR);
-    tcg_out32(s, LD | RT(11) | RA(reg) | 16);
-    tcg_out32(s, LD | RT(2) | RA(reg) | 8);
+    tcg_out32(s, LD | TAI(11, reg, 16));
+    tcg_out32(s, LD | TAI(2, reg, 8));
     tcg_out32(s, BCCTR | BO_ALWAYS | LK);
 #endif
 }
@@ -963,12 +963,9 @@ static void tcg_out_qemu_st(TCGContext *s, const TCGArg *args, int opc)
     reloc_pc14(label1_ptr, (tcg_target_long)s->code_ptr);
 #endif
 
-    tcg_out32(s, (LD
-                   | RT(r0)
-                   | RA(r0)
-                   | (offsetof(CPUTLBEntry, addend)
-                      - offsetof(CPUTLBEntry, addr_write))
-                   ));
+    tcg_out32(s, LD | TAI(r0, r0, 
+                          offsetof(CPUTLBEntry, addend)
+                          - offsetof(CPUTLBEntry, addr_write)));
     /* r0 = env->tlb_table[mem_index][index].addend */
     tcg_out32(s, ADD | TAB(r0, r0, addr_reg));
     /* r0 = env->tlb_table[mem_index][index].addend + addr */
@@ -1030,15 +1027,12 @@ static void tcg_target_qemu_prologue(TCGContext *s)
 
     /* Prologue */
     tcg_out32(s, MFSPR | RT(0) | LR);
-    tcg_out32(s, STDU | RS(1) | RA(1) | (-frame_size & 0xffff));
-    for (i = 0; i < ARRAY_SIZE(tcg_target_callee_save_regs); ++i)
-        tcg_out32(s, (STD
-                       | RS(tcg_target_callee_save_regs[i])
-                       | RA(1)
-                       | (i * 8 + 48 + TCG_STATIC_CALL_ARGS_SIZE)
-                       )
-            );
-    tcg_out32(s, STD | RS(0) | RA(1) | (frame_size + 16));
+    tcg_out32(s, STDU | SAI(1, 1, -frame_size));
+    for (i = 0; i < ARRAY_SIZE(tcg_target_callee_save_regs); ++i) {
+        tcg_out32(s, STD | SAI(tcg_target_callee_save_regs[i], 1, 
+                               i * 8 + 48 + TCG_STATIC_CALL_ARGS_SIZE));
+    }
+    tcg_out32(s, STD | SAI(0, 1, frame_size + 16));
 
 #ifdef CONFIG_USE_GUEST_BASE
     if (GUEST_BASE) {
@@ -1054,13 +1048,10 @@ static void tcg_target_qemu_prologue(TCGContext *s)
     /* Epilogue */
     tb_ret_addr = s->code_ptr;
 
-    for (i = 0; i < ARRAY_SIZE(tcg_target_callee_save_regs); ++i)
-        tcg_out32(s, (LD
-                       | RT(tcg_target_callee_save_regs[i])
-                       | RA(1)
-                       | (i * 8 + 48 + TCG_STATIC_CALL_ARGS_SIZE)
-                       )
-            );
+    for (i = 0; i < ARRAY_SIZE(tcg_target_callee_save_regs); ++i) {
+        tcg_out32(s, LD | TAI(tcg_target_callee_save_regs[i], 1,
+                              i * 8 + 48 + TCG_STATIC_CALL_ARGS_SIZE));
+    }
     tcg_out32(s, LD | TAI(0, 1, frame_size + 16));
     tcg_out32(s, MTSPR | RS(0) | LR);
     tcg_out32(s, ADDI | TAI(1, 1, frame_size));
-- 
1.8.3.1

  parent reply	other threads:[~2013-09-01 16:16 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-01 16:15 [Qemu-devel] [PATCH 00/14] tcg-ppc64 improvements Richard Henderson
2013-09-01 16:16 ` [Qemu-devel] [PATCH 01/14] tcg-ppc64: Reformat tcg-target.c Richard Henderson
2013-09-01 16:16 ` Richard Henderson [this message]
2013-09-01 16:16 ` [Qemu-devel] [PATCH 03/14] tcg-ppc64: Use TCG_REG_Rn constants Richard Henderson
2013-09-01 16:16 ` [Qemu-devel] [PATCH 04/14] tcg-ppc64: Use tcg_out64 Richard Henderson
2013-09-01 16:16 ` [Qemu-devel] [PATCH 05/14] tcg-ppc64: Avoid code for nop move Richard Henderson
2013-09-01 16:16 ` [Qemu-devel] [PATCH 06/14] tcg-ppc64: Don't load the static chain from TCG Richard Henderson
2013-09-01 16:16 ` [Qemu-devel] [PATCH 07/14] tcg-ppc64: Fold constant call address into descriptor load Richard Henderson
2013-09-01 16:16 ` [Qemu-devel] [PATCH 08/14] tcg-ppc64: Look through a constant function descriptor Richard Henderson
2013-09-01 16:16 ` [Qemu-devel] [PATCH 09/14] tcg-ppc64: Tidy register allocation order Richard Henderson
2013-09-01 16:16 ` [Qemu-devel] [PATCH 10/14] tcg-ppc64: Handle long offsets better Richard Henderson
2013-09-01 16:16 ` [Qemu-devel] [PATCH 11/14] tcg-ppc64: Implement tcg_register_jit Richard Henderson
2013-09-01 16:16 ` [Qemu-devel] [PATCH 12/14] tcg-ppc64: Streamline tcg_out_tlb_read Richard Henderson
2013-09-01 16:16 ` [Qemu-devel] [PATCH 13/14] tcg-ppc64: Add _noaddr functions for emitting forward branches Richard Henderson
2013-09-01 16:16 ` [Qemu-devel] [PATCH 14/14] tcg-ppc64: Implement CONFIG_QEMU_LDST_OPTIMIZATION Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1378052173-3579-3-git-send-email-rth@twiddle.net \
    --to=rth@twiddle.net \
    --cc=aurelien@aurel32.net \
    --cc=av1474@comtv.ru \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).