From: Gerd Hoffmann <kraxel@redhat.com>
To: Christophe Fergeau <cfergeau@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] spice-core: Use g_strdup_printf instead of snprintf
Date: Mon, 02 Sep 2013 13:36:19 +0200 [thread overview]
Message-ID: <1378121779.14555.3.camel@nilsson.home.kraxel.org> (raw)
In-Reply-To: <1378115620-13187-1-git-send-email-cfergeau@redhat.com>
On Mo, 2013-09-02 at 11:53 +0200, Christophe Fergeau wrote:
> Several places in spice-core.c were using either g_malloc+snprintf
> or snprintf+g_strdup to achieve the same result as g_strdup_printf.
Patch looks good but fails checkpatch.pl due to long lines.
cheers,
Gerd
next prev parent reply other threads:[~2013-09-02 11:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-02 9:53 [Qemu-devel] [PATCH] spice-core: Use g_strdup_printf instead of snprintf Christophe Fergeau
2013-09-02 10:30 ` Marc-André Lureau
2013-09-02 11:36 ` Gerd Hoffmann [this message]
2013-09-02 13:44 ` Christophe Fergeau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1378121779.14555.3.camel@nilsson.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=cfergeau@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).