qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <rth@twiddle.net>
To: qemu-devel@nongnu.org
Cc: aurelien@aurel32.net, anthony@codemonkey.ws
Subject: [Qemu-devel] [PULL 29/29] tcg-i386: Make use of zero-extended memory helper routines
Date: Mon,  2 Sep 2013 09:29:14 -0700	[thread overview]
Message-ID: <1378139354-28602-30-git-send-email-rth@twiddle.net> (raw)
In-Reply-To: <1378139354-28602-1-git-send-email-rth@twiddle.net>

For 8 and 16-bit unsigned loads, rely on the zero-extension
from the helper and use a smaller 32-bit move insn.

Reviewed-by: Aurelien Jarno <aurelien@aurel32.net>
Signed-off-by: Richard Henderson <rth@twiddle.net>
---
 tcg/i386/tcg-target.c | 15 ++++++---------
 1 file changed, 6 insertions(+), 9 deletions(-)

diff --git a/tcg/i386/tcg-target.c b/tcg/i386/tcg-target.c
index 3ee54f1..c1f0741 100644
--- a/tcg/i386/tcg-target.c
+++ b/tcg/i386/tcg-target.c
@@ -1531,20 +1531,17 @@ static void tcg_out_qemu_ld_slow_path(TCGContext *s, TCGLabelQemuLdst *l)
     case 1 | 4:
         tcg_out_ext16s(s, data_reg, TCG_REG_EAX, P_REXW);
         break;
-    case 0:
-        tcg_out_ext8u(s, data_reg, TCG_REG_EAX);
-        break;
-    case 1:
-        tcg_out_ext16u(s, data_reg, TCG_REG_EAX);
-        break;
-    case 2:
-        tcg_out_mov(s, TCG_TYPE_I32, data_reg, TCG_REG_EAX);
-        break;
 #if TCG_TARGET_REG_BITS == 64
     case 2 | 4:
         tcg_out_ext32s(s, data_reg, TCG_REG_EAX);
         break;
 #endif
+    case 0:
+    case 1:
+        /* Note that the helpers have zero-extended to tcg_target_long.  */
+    case 2:
+        tcg_out_mov(s, TCG_TYPE_I32, data_reg, TCG_REG_EAX);
+        break;
     case 3:
         if (TCG_TARGET_REG_BITS == 64) {
             tcg_out_mov(s, TCG_TYPE_I64, data_reg, TCG_REG_RAX);
-- 
1.8.1.4

  parent reply	other threads:[~2013-09-02 16:30 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-02 16:28 [Qemu-devel] [PULL 00/29] Three tcg patch sets Richard Henderson
2013-09-02 16:28 ` [Qemu-devel] [PULL 01/29] tcg: Add muluh and mulsh opcodes Richard Henderson
2013-09-02 16:28 ` [Qemu-devel] [PULL 02/29] tcg-mips: Implement mulsh, muluh Richard Henderson
2013-09-02 16:28 ` [Qemu-devel] [PULL 03/29] tcg-ppc64: Implement muluh, mulsh Richard Henderson
2013-09-02 16:28 ` [Qemu-devel] [PULL 04/29] tcg: Constant fold div, rem Richard Henderson
2013-09-02 16:28 ` [Qemu-devel] [PULL 05/29] qtest: Fix FMT_timeval vs time_t Richard Henderson
2013-09-02 16:28 ` [Qemu-devel] [PULL 06/29] tcg: Change flush_icache_range arguments to uintptr_t Richard Henderson
2013-09-02 16:28 ` [Qemu-devel] [PULL 07/29] tcg: Change tcg_qemu_tb_exec return " Richard Henderson
2013-09-02 16:28 ` [Qemu-devel] [PULL 08/29] tcg: Fix next_tb type in cpu_exec Richard Henderson
2013-09-02 16:28 ` [Qemu-devel] [PULL 09/29] tcg: Allow TCG_TARGET_REG_BITS to be specified independantly Richard Henderson
2013-09-02 16:28 ` [Qemu-devel] [PULL 10/29] tcg: Define TCG_TYPE_PTR properly Richard Henderson
2013-09-02 16:28 ` [Qemu-devel] [PULL 11/29] tcg: Define TCG_ptr properly Richard Henderson
2013-09-02 16:28 ` [Qemu-devel] [PULL 12/29] tcg: Change frame pointer offsets to intptr_t Richard Henderson
2013-09-02 16:28 ` [Qemu-devel] [PULL 13/29] tcg: Change memory " Richard Henderson
2013-09-02 16:28 ` [Qemu-devel] [PULL 14/29] tcg: Change relocation " Richard Henderson
2013-09-02 16:29 ` [Qemu-devel] [PULL 15/29] tcg: Use uintptr_t in TCGHelperInfo Richard Henderson
2013-09-02 16:29 ` [Qemu-devel] [PULL 16/29] tcg: Change tcg_gen_exit_tb argument to uintptr_t Richard Henderson
2013-09-02 16:29 ` [Qemu-devel] [PULL 17/29] tcg: Change tcg_out_ld/st offset to intptr_t Richard Henderson
2013-09-02 16:29 ` [Qemu-devel] [PULL 18/29] tcg: Use appropriate types in tcg_reg_alloc_call Richard Henderson
2013-09-02 16:29 ` [Qemu-devel] [PULL 19/29] tcg: Fix jit debug for x32 Richard Henderson
2013-09-02 16:29 ` [Qemu-devel] [PULL 20/29] tcg-i386: Use intptr_t appropriately Richard Henderson
2013-09-02 16:29 ` [Qemu-devel] [PULL 21/29] tcg-i386: Adjust tcg_out_tlb_load for x32 Richard Henderson
2013-09-02 16:29 ` [Qemu-devel] [PULL 22/29] configure: Allow x32 as a host Richard Henderson
2013-09-02 16:29 ` [Qemu-devel] [PULL 23/29] exec: Reorganize the GETRA/GETPC macros Richard Henderson
2013-09-02 16:29 ` [Qemu-devel] [PULL 24/29] tcg-i386: Don't perform GETPC adjustment in TCG code Richard Henderson
2013-09-02 16:29 ` [Qemu-devel] [PULL 25/29] exec: Rename USUFFIX to LSUFFIX Richard Henderson
2013-09-02 16:29 ` [Qemu-devel] [PULL 26/29] target: Include softmmu_exec.h where forgotten Richard Henderson
2013-09-02 16:29 ` [Qemu-devel] [PULL 27/29] exec: Split softmmu_defs.h Richard Henderson
2013-09-02 16:29 ` [Qemu-devel] [PULL 28/29] tcg: Introduce zero and sign-extended versions of load helpers Richard Henderson
2013-09-02 16:29 ` Richard Henderson [this message]
2013-09-03  6:13 ` [Qemu-devel] [PULL 00/29] Three tcg patch sets Aurelien Jarno

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1378139354-28602-30-git-send-email-rth@twiddle.net \
    --to=rth@twiddle.net \
    --cc=anthony@codemonkey.ws \
    --cc=aurelien@aurel32.net \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).