From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44446) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VGlP8-0007oY-Ci for qemu-devel@nongnu.org; Tue, 03 Sep 2013 03:52:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VGlP2-00062U-5g for qemu-devel@nongnu.org; Tue, 03 Sep 2013 03:52:02 -0400 Received: from mx1.redhat.com ([209.132.183.28]:8929) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VGlP1-00062Q-UL for qemu-devel@nongnu.org; Tue, 03 Sep 2013 03:51:56 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r837psNe002936 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 3 Sep 2013 03:51:55 -0400 Message-ID: <1378194712.3618.12.camel@nilsson.home.kraxel.org> From: Gerd Hoffmann Date: Tue, 03 Sep 2013 09:51:52 +0200 In-Reply-To: <20130902125757.GH15704@redhat.com> References: <1378114724-1748-1-git-send-email-gren@redhat.com> <1378114724-1748-4-git-send-email-gren@redhat.com> <20130902125757.GH15704@redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [libvirt] [PATCH 3/5] qemu: add usb-bot support from disks points of view List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" Cc: libvir-list@redhat.com, Guannan Ren , qemu-devel@nongnu.org On Mo, 2013-09-02 at 13:57 +0100, Daniel P. Berrange wrote: > On Mon, Sep 02, 2013 at 05:38:42PM +0800, Guannan Ren wrote: > > usb-bot only supports 16 luns(0~15) and they must be contiguous, > > (using lun 0 and 2 without 1 doesn't work). In this case qemu > > doesn't throw an error, we can not find the lun 2 in guests. So > > Adding a checking function in libvirt to prevent from this case. > > Hmm, this seems like a problematic restriction. It's how the hardware works. > How does this work if we start off a guest with 3 disks > attached to the usb-bot SCSI controller. Then hot-unplug > the 2nd disk. You can't hotplug individual luns anyway. cheers, Gerd