From: Gerd Hoffmann <kraxel@redhat.com>
To: Miroslav Rezanina <mrezanin@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCHv2] Make usb-bt-dongle configurable
Date: Tue, 03 Sep 2013 13:33:41 +0200 [thread overview]
Message-ID: <1378208021.3618.26.camel@nilsson.home.kraxel.org> (raw)
In-Reply-To: <1521731216.5957480.1378197971859.JavaMail.root@redhat.com>
> > This (and some other bits) are pure code motion from vl.c, correct?
> > Can you split this into a separate patch please? That'll simplify the
> > review o the actual code changes.
>
> Yes, this is pure code motion. I'll split the code to separate patches.
> >
> > It also doesn't make much sense to compile hw/bt/ with
> > CONFIG_USB_BLUETOOTH=n. It's basically dead code then.
> >
>
> Is this true? So -bt option is not useable without usb-bt-dongle?
Ahem, well, double-checked: No.
n800+n810 emulation (qemu-system-arm) has a bluetooth hci too.
So we need a separate CONFIG_BLUETOOTH for hw/bt/, so we can enable it
for both arm emulation and for CONFIG_USB_BLUETOOTH=y. Maybe it makes
sense to wait until we have kconfig.
cheers,
Gerd
next prev parent reply other threads:[~2013-09-03 11:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-03 7:26 [Qemu-devel] [PATCHv2] Make usb-bt-dongle configurable mrezanin
2013-09-03 7:41 ` Gerd Hoffmann
2013-09-03 8:46 ` Miroslav Rezanina
2013-09-03 11:33 ` Gerd Hoffmann [this message]
2013-09-03 8:34 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1378208021.3618.26.camel@nilsson.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=mrezanin@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).