From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39115)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1VGorn-0007Oz-PA
	for qemu-devel@nongnu.org; Tue, 03 Sep 2013 07:33:57 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1VGorh-0005My-9t
	for qemu-devel@nongnu.org; Tue, 03 Sep 2013 07:33:51 -0400
Received: from mx1.redhat.com ([209.132.183.28]:35230)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1VGorh-0005Ms-1l
	for qemu-devel@nongnu.org; Tue, 03 Sep 2013 07:33:45 -0400
Received: from int-mx11.intmail.prod.int.phx2.redhat.com
	(int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r83BXhde032280
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Tue, 3 Sep 2013 07:33:43 -0400
Message-ID: <1378208021.3618.26.camel@nilsson.home.kraxel.org>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Tue, 03 Sep 2013 13:33:41 +0200
In-Reply-To: <1521731216.5957480.1378197971859.JavaMail.root@redhat.com>
References: <fc4ad2cce7093425d113dd2d8f97048a990413cd.1378192732.git.mrezanin@redhat.com>
	<1378194071.3618.8.camel@nilsson.home.kraxel.org>
	<1521731216.5957480.1378197971859.JavaMail.root@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCHv2] Make usb-bt-dongle configurable
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Miroslav Rezanina <mrezanin@redhat.com>
Cc: qemu-devel@nongnu.org

> > This (and some other bits) are pure code motion from vl.c, correct?
> > Can you split this into a separate patch please?  That'll simplify the
> > review o the actual code changes.
> 
> Yes, this is pure code motion. I'll split the code to separate patches.
> > 
> > It also doesn't make much sense to compile hw/bt/ with
> > CONFIG_USB_BLUETOOTH=n.  It's basically dead code then.
> > 
> 
> Is this true? So -bt option is not useable without usb-bt-dongle? 

Ahem, well, double-checked:  No.

n800+n810 emulation (qemu-system-arm) has a bluetooth hci too.

So we need a separate CONFIG_BLUETOOTH for hw/bt/, so we can enable it
for both arm emulation and for CONFIG_USB_BLUETOOTH=y.  Maybe it makes
sense to wait until we have kconfig.

cheers,
  Gerd