From: Gerd Hoffmann <kraxel@redhat.com>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: libvir-list@redhat.com, Guannan Ren <gren@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [libvirt] [PATCH 3/5] qemu: add usb-bot support from disks points of view
Date: Tue, 03 Sep 2013 14:06:44 +0200 [thread overview]
Message-ID: <1378210004.3618.40.camel@nilsson.home.kraxel.org> (raw)
In-Reply-To: <20130903093231.GD32024@redhat.com>
Hi,
> > > How does this work if we start off a guest with 3 disks
> > > attached to the usb-bot SCSI controller. Then hot-unplug
> > > the 2nd disk.
> >
> > You can't hotplug individual luns anyway.
>
> How does hotplug/unplug work in the context of usb-bot ?
>
> AFAIK we need to be able to run
>
> device_add usb_bot
> drive_add file...
> device_add scsi-hd
>
> And the reverse, to unplug it, if we're to have feature parity with
> usb-storage.
Hot-unplug is easy. You can remove the usb-bot device which will also
remove all child devices.
Hot-plug doesn't work at the moment, and I don't see any obvious way to
fix that properly :-(
We need some way to hotplug a *group* of devices (usb-bot + all
children) as usb-bot itself is hotpluggable but the individual scsi
devices connected to it are not.
I could allow hotplug on usb-bot as workaround, then you can do
stop
device_add usb_bot
device_add scsi-{hd,cd,whatever}
cont
but that would be more a gross hack than a solution ...
cheers,
Gerd
prev parent reply other threads:[~2013-09-03 12:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1378114724-1748-1-git-send-email-gren@redhat.com>
[not found] ` <1378114724-1748-4-git-send-email-gren@redhat.com>
2013-09-02 12:57 ` [Qemu-devel] [libvirt] [PATCH 3/5] qemu: add usb-bot support from disks points of view Daniel P. Berrange
2013-09-03 3:26 ` Guannan Ren
2013-09-03 7:51 ` Gerd Hoffmann
2013-09-03 9:32 ` Daniel P. Berrange
2013-09-03 12:06 ` Gerd Hoffmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1378210004.3618.40.camel@nilsson.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=berrange@redhat.com \
--cc=gren@redhat.com \
--cc=libvir-list@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).