From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49184) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VH90p-0002k9-TG for qemu-devel@nongnu.org; Wed, 04 Sep 2013 05:04:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VH90g-0007PV-NM for qemu-devel@nongnu.org; Wed, 04 Sep 2013 05:04:31 -0400 Received: from e23smtp01.au.ibm.com ([202.81.31.143]:53401) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VH90g-0007PD-4h for qemu-devel@nongnu.org; Wed, 04 Sep 2013 05:04:22 -0400 Received: from /spool/local by e23smtp01.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 4 Sep 2013 18:53:27 +1000 Received: from d23relay05.au.ibm.com (d23relay05.au.ibm.com [9.190.235.152]) by d23dlp02.au.ibm.com (Postfix) with ESMTP id 5CD102BB0051 for ; Wed, 4 Sep 2013 19:04:11 +1000 (EST) Received: from d23av04.au.ibm.com (d23av04.au.ibm.com [9.190.235.139]) by d23relay05.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r848lltx54329572 for ; Wed, 4 Sep 2013 18:47:47 +1000 Received: from d23av04.au.ibm.com (loopback [127.0.0.1]) by d23av04.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r84949tA029420 for ; Wed, 4 Sep 2013 19:04:10 +1000 From: Lei Li Date: Wed, 4 Sep 2013 17:02:35 +0800 Message-Id: <1378285356-5308-3-git-send-email-lilei@linux.vnet.ibm.com> In-Reply-To: <1378285356-5308-1-git-send-email-lilei@linux.vnet.ibm.com> References: <1378285356-5308-1-git-send-email-lilei@linux.vnet.ibm.com> Subject: [Qemu-devel] [PATCH 2/3 resend v2] savevm: fix wrong initialization by ram_control_load_hook List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: pbonzini@redhat.com, Lei Li , anthony@codemonkey.ws, mrhines@linux.vnet.ibm.com, quintela@redhat.com It should set negative error value rather than 0 in QEMUFile if there has been an error. Reviewed-by: Michael R. Hines Signed-off-by: Lei Li --- Change since v1: Initialize ret to -EINVAL rather than -1 from Paolo Bonzini. savevm.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/savevm.c b/savevm.c index 95a11f9..a0be109 100644 --- a/savevm.c +++ b/savevm.c @@ -649,7 +649,7 @@ void ram_control_after_iterate(QEMUFile *f, uint64_t flags) void ram_control_load_hook(QEMUFile *f, uint64_t flags) { - int ret = 0; + int ret = -EINVAL; if (f->ops->hook_ram_load) { ret = f->ops->hook_ram_load(f, f->opaque, flags); -- 1.7.7.6