qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org
Cc: imammedo@redhat.com
Subject: [Qemu-devel] [PATCH 1/6] q35: make pci window address/size match guest cfg
Date: Wed, 4 Sep 2013 13:48:29 +0300	[thread overview]
Message-ID: <1378291667-8516-2-git-send-email-mst@redhat.com> (raw)
In-Reply-To: <1378291667-8516-1-git-send-email-mst@redhat.com>

For Q35, MMCFG address and size are guest configurable.
Update w32 property to make it behave accordingly.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 hw/pci-host/q35.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/hw/pci-host/q35.c b/hw/pci-host/q35.c
index 4febd24..3f1d447 100644
--- a/hw/pci-host/q35.c
+++ b/hw/pci-host/q35.c
@@ -214,6 +214,16 @@ static void mch_update_pciexbar(MCHPCIState *mch)
     }
     addr = pciexbar & addr_mask;
     pcie_host_mmcfg_update(pehb, enable, addr, length);
+    /* Leave enough space for the MCFG BAR */
+    /*
+     * TODO: this matches current bios behaviour, but it's not a power of two,
+     * which means an MTRR can't cover it exactly.
+     */
+    if (enable) {
+        mch->pci_info.w32.begin = addr + length;
+    } else {
+        mch->pci_info.w32.begin = MCH_HOST_BRIDGE_PCIEXBAR_DEFAULT;
+    }
 }
 
 /* PAM */
-- 
MST

  reply	other threads:[~2013-09-04 10:46 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-04 10:48 [Qemu-devel] [PATCH 0/6] pci: keep window properties up to date Michael S. Tsirkin
2013-09-04 10:48 ` Michael S. Tsirkin [this message]
2013-09-10 13:37   ` [Qemu-devel] [PATCH 1/6] q35: make pci window address/size match guest cfg Igor Mammedov
2013-09-10 13:46     ` Michael S. Tsirkin
2013-09-10 13:46       ` Igor Mammedov
2013-09-10 13:53         ` Michael S. Tsirkin
2013-09-10 14:09           ` Igor Mammedov
2013-09-10 14:16             ` Michael S. Tsirkin
2013-09-10 15:05               ` Igor Mammedov
2013-09-10 15:25                 ` Michael S. Tsirkin
2013-09-04 10:48 ` [Qemu-devel] [PATCH 2/6] range: add Range to typedefs Michael S. Tsirkin
2013-09-04 10:48 ` [Qemu-devel] [PATCH 3/6] range: add min/max operations on ranges Michael S. Tsirkin
2013-09-10  9:35   ` Igor Mammedov
2013-09-10 12:51     ` Michael S. Tsirkin
2013-09-04 10:48 ` [Qemu-devel] [PATCH 4/6] pci: add helper to retrieve the 64-bit range Michael S. Tsirkin
2013-09-10 13:40   ` Igor Mammedov
2013-09-10 13:50     ` Michael S. Tsirkin
2013-09-10 17:05       ` Igor Mammedov
2013-09-10 17:28         ` Michael S. Tsirkin
2013-09-04 10:48 ` [Qemu-devel] [PATCH 5/6] q35: use 64 bit window programmed by guest Michael S. Tsirkin
2013-09-10 14:12   ` Igor Mammedov
2013-09-10 14:19     ` Michael S. Tsirkin
2013-09-04 10:48 ` [Qemu-devel] [PATCH 6/6] piix: " Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1378291667-8516-2-git-send-email-mst@redhat.com \
    --to=mst@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).