From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55590) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VHGRy-0002bu-Tj for qemu-devel@nongnu.org; Wed, 04 Sep 2013 13:01:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VHGRp-00062o-Gv for qemu-devel@nongnu.org; Wed, 04 Sep 2013 13:01:02 -0400 Received: from mail-qc0-x232.google.com ([2607:f8b0:400d:c01::232]:46949) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VHGRp-00062b-Dh for qemu-devel@nongnu.org; Wed, 04 Sep 2013 13:00:53 -0400 Received: by mail-qc0-f178.google.com with SMTP id r5so318798qcx.37 for ; Wed, 04 Sep 2013 10:00:53 -0700 (PDT) Sender: Paolo Bonzini From: Paolo Bonzini Date: Wed, 4 Sep 2013 19:00:20 +0200 Message-Id: <1378314038-15525-4-git-send-email-pbonzini@redhat.com> In-Reply-To: <1378314038-15525-1-git-send-email-pbonzini@redhat.com> References: <1378314038-15525-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PATCH v5 03/21] cow: do not call bdrv_co_is_allocated List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: stefanha@redhat.com As we change bdrv_is_allocated to gather more information from bs and bs->file, it will become a bit slower. It is still appropriate for online jobs, but not for reads/writes. Call the internal function instead. Reviewed-by: Eric Blake Signed-off-by: Paolo Bonzini --- block/cow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/cow.c b/block/cow.c index 9ae2d6a..55bac50 100644 --- a/block/cow.c +++ b/block/cow.c @@ -212,7 +212,7 @@ static int coroutine_fn cow_read(BlockDriverState *bs, int64_t sector_num, int ret, n; while (nb_sectors > 0) { - if (bdrv_co_is_allocated(bs, sector_num, nb_sectors, &n)) { + if (cow_co_is_allocated(bs, sector_num, nb_sectors, &n)) { ret = bdrv_pread(bs->file, s->cow_sectors_offset + sector_num * 512, buf, n * 512); -- 1.8.3.1