qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Alexey Kardashevskiy <aik@ozlabs.ru>
To: qemu-devel@nongnu.org
Cc: Alexey Kardashevskiy <aik@ozlabs.ru>,
	qemu-ppc@nongnu.org, Paul Mackerras <paulus@samba.org>,
	Alexander Graf <agraf@suse.de>
Subject: [Qemu-devel] [PATCH] spapr-rtas: reset top 4 bits in parameters address
Date: Thu,  5 Sep 2013 15:58:20 +1000	[thread overview]
Message-ID: <1378360700-4300-1-git-send-email-aik@ozlabs.ru> (raw)

On the real hardware, RTAS is called in real mode and therefore
ignores top 4 bits of the address passed in the call.

This fixes QEMU to do the same thing.

Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
---
 hw/ppc/spapr_rtas.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/hw/ppc/spapr_rtas.c b/hw/ppc/spapr_rtas.c
index eb542f2..ab03d67 100644
--- a/hw/ppc/spapr_rtas.c
+++ b/hw/ppc/spapr_rtas.c
@@ -240,7 +240,8 @@ target_ulong spapr_rtas_call(PowerPCCPU *cpu, sPAPREnvironment *spapr,
         struct rtas_call *call = rtas_table + (token - TOKEN_BASE);
 
         if (call->fn) {
-            call->fn(cpu, spapr, token, nargs, args, nret, rets);
+            call->fn(cpu, spapr, token, nargs, args & 0x0FFFFFFFFFFFFFFFUL,
+                     nret, rets);
             return H_SUCCESS;
         }
     }
-- 
1.8.4.rc4

             reply	other threads:[~2013-09-05  5:59 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-05  5:58 Alexey Kardashevskiy [this message]
2013-09-05  7:08 ` [Qemu-devel] [PATCH] spapr-rtas: reset top 4 bits in parameters address Alexander Graf
2013-09-05  7:40   ` Alexey Kardashevskiy
2013-09-05  9:27     ` Alexander Graf
2013-09-05 10:17       ` Alexey Kardashevskiy
2013-09-05 10:21         ` Alexander Graf
2013-09-05 12:04           ` Alexey Kardashevskiy
2013-09-05 12:16             ` Alexander Graf
2013-09-05 12:49               ` Alexey Kardashevskiy
2013-09-05 13:08                 ` Alexander Graf
2013-09-05 14:24                   ` Alexey Kardashevskiy
2013-09-06  5:04                     ` Alexey Kardashevskiy
2013-09-06  6:22                       ` Alexander Graf
2013-09-06  6:43                         ` Alexey Kardashevskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1378360700-4300-1-git-send-email-aik@ozlabs.ru \
    --to=aik@ozlabs.ru \
    --cc=agraf@suse.de \
    --cc=paulus@samba.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).