qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: ehabkost@redhat.com, gleb@redhat.com, kvm@vger.kernel.org
Subject: [Qemu-devel] [PATCH uq/master 1/2] x86: fix migration from pre-version 12
Date: Thu,  5 Sep 2013 15:06:21 +0200	[thread overview]
Message-ID: <1378386382-415-2-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1378386382-415-1-git-send-email-pbonzini@redhat.com>

On KVM, the KVM_SET_XSAVE would be executed with a 0 xstate_bv,
and not restore anything.

Since FP and SSE data are always valid, set them in xstate_bv at reset
time.  In fact, that value is the same that KVM_GET_XSAVE returns on
pre-XSAVE hosts.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 target-i386/cpu.c | 1 +
 target-i386/cpu.h | 5 +++++
 2 files changed, 6 insertions(+)

diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index c36345e..ac83106 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -2386,6 +2386,7 @@ static void x86_cpu_reset(CPUState *s)
     env->fpuc = 0x37f;
 
     env->mxcsr = 0x1f80;
+    env->xstate_bv = XSTATE_FP | XSTATE_SSE;
 
     env->pat = 0x0007040600070406ULL;
     env->msr_ia32_misc_enable = MSR_IA32_MISC_ENABLE_DEFAULT;
diff --git a/target-i386/cpu.h b/target-i386/cpu.h
index 5723eff..a153078 100644
--- a/target-i386/cpu.h
+++ b/target-i386/cpu.h
@@ -380,6 +380,11 @@
 
 #define MSR_VM_HSAVE_PA                 0xc0010117
 
+#define XSTATE_SUPPORTED		(XSTATE_FP|XSTATE_SSE|XSTATE_YMM)
+#define XSTATE_FP			1
+#define XSTATE_SSE			2
+#define XSTATE_YMM			4
+
 /* CPUID feature words */
 typedef enum FeatureWord {
     FEAT_1_EDX,         /* CPUID[1].EDX */
-- 
1.8.3.1

  reply	other threads:[~2013-09-05 13:06 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-05 13:06 [Qemu-devel] [PATCH uq/master 0/2] KVM: issues with XSAVE support Paolo Bonzini
2013-09-05 13:06 ` Paolo Bonzini [this message]
2013-09-08 11:40   ` [Qemu-devel] [PATCH uq/master 1/2] x86: fix migration from pre-version 12 Gleb Natapov
2013-09-09  8:31     ` Paolo Bonzini
2013-09-09  9:03       ` Gleb Natapov
2013-09-09  9:53         ` Paolo Bonzini
2013-09-09 10:54           ` Gleb Natapov
2013-09-09 10:58             ` Gleb Natapov
2013-09-09 11:07             ` Paolo Bonzini
2013-09-09 11:28               ` Gleb Natapov
2013-09-09 11:46                 ` Paolo Bonzini
2013-09-09 12:00                   ` Gleb Natapov
2013-09-05 13:06 ` [Qemu-devel] [PATCH uq/master 2/2] KVM: make XSAVE support more robust Paolo Bonzini
2013-09-08 11:52   ` Gleb Natapov
2013-09-09  8:51     ` Paolo Bonzini
2013-09-09  9:18       ` Gleb Natapov
2013-09-09  9:50         ` Paolo Bonzini
2013-09-09 10:41           ` Gleb Natapov
2013-09-09 12:00             ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1378386382-415-2-git-send-email-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=gleb@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).