From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: qemu-stable@nongnu.org, anthony@codemonkey.ws
Subject: [Qemu-devel] [PULL 1/5] exec: fix writing to MMIO area with non-power-of-two length
Date: Thu, 5 Sep 2013 19:17:31 +0200 [thread overview]
Message-ID: <1378401455-583-2-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1378401455-583-1-git-send-email-pbonzini@redhat.com>
The problem is introduced by commit 2332616 (exec: Support 64-bit
operations in address_space_rw, 2013-07-08). Before that commit,
memory_access_size would only return 1/2/4.
Since alignment is already handled above, reduce l to the largest
power of two that is smaller than l.
Cc: qemu-stable@nongnu.org
Reported-by: Oleksii Shevchuk <alxchk@gmail.com>
Tested-by: Oleksii Shevchuk <alxchk@gmail.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
exec.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/exec.c b/exec.c
index 87b0b39..b52ec80 100644
--- a/exec.c
+++ b/exec.c
@@ -1913,6 +1913,9 @@ static int memory_access_size(MemoryRegion *mr, unsigned l, hwaddr addr)
if (l > access_size_max) {
l = access_size_max;
}
+ if (l & (l - 1)) {
+ l = 1 << (qemu_fls(l) - 1);
+ }
return l;
}
--
1.8.3.1
next prev parent reply other threads:[~2013-09-05 17:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-05 17:17 [Qemu-devel] [PULL 0/5] Memory patches for 2013-09-05 Paolo Bonzini
2013-09-05 17:17 ` Paolo Bonzini [this message]
2013-09-05 17:17 ` [Qemu-devel] [PULL 2/5] exec: check offset_within_address_space for register subpage Paolo Bonzini
2013-09-05 17:17 ` [Qemu-devel] [PULL 3/5] memory: Provide separate handling of unassigned io ports accesses Paolo Bonzini
2013-09-05 17:17 ` [Qemu-devel] [PULL 4/5] Revert "memory: Return -1 again on reads from unsigned regions" Paolo Bonzini
2013-09-05 17:17 ` [Qemu-devel] [PULL 5/5] exec: do tcg_commit only when tcg_enabled Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1378401455-583-2-git-send-email-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).