qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: Jan Kiszka <jan.kiszka@siemens.com>,
	qemu-stable@nongnu.org, anthony@codemonkey.ws
Subject: [Qemu-devel] [PULL 4/5] Revert "memory: Return -1 again on reads from unsigned regions"
Date: Thu,  5 Sep 2013 19:17:34 +0200	[thread overview]
Message-ID: <1378401455-583-5-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1378401455-583-1-git-send-email-pbonzini@redhat.com>

From: Jan Kiszka <jan.kiszka@siemens.com>

This reverts commit 9b8c69243585a32d14b9bb9fcd52c37b0b5a1b71.

The commit was wrong: We only return -1 on invalid accesses, not on
valid but unbacked ones. This broke various corner cases.

Cc: qemu-stable@nongnu.org
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 memory.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/memory.c b/memory.c
index 886f838..5a10fd0 100644
--- a/memory.c
+++ b/memory.c
@@ -872,7 +872,7 @@ static uint64_t unassigned_mem_read(void *opaque, hwaddr addr,
     if (current_cpu != NULL) {
         cpu_unassigned_access(current_cpu, addr, false, false, 0, size);
     }
-    return -1ULL;
+    return 0;
 }
 
 static void unassigned_mem_write(void *opaque, hwaddr addr,
-- 
1.8.3.1

  parent reply	other threads:[~2013-09-05 17:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-05 17:17 [Qemu-devel] [PULL 0/5] Memory patches for 2013-09-05 Paolo Bonzini
2013-09-05 17:17 ` [Qemu-devel] [PULL 1/5] exec: fix writing to MMIO area with non-power-of-two length Paolo Bonzini
2013-09-05 17:17 ` [Qemu-devel] [PULL 2/5] exec: check offset_within_address_space for register subpage Paolo Bonzini
2013-09-05 17:17 ` [Qemu-devel] [PULL 3/5] memory: Provide separate handling of unassigned io ports accesses Paolo Bonzini
2013-09-05 17:17 ` Paolo Bonzini [this message]
2013-09-05 17:17 ` [Qemu-devel] [PULL 5/5] exec: do tcg_commit only when tcg_enabled Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1378401455-583-5-git-send-email-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=anthony@codemonkey.ws \
    --cc=jan.kiszka@siemens.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-stable@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).