From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50856) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VHiFZ-0004e0-VY for qemu-devel@nongnu.org; Thu, 05 Sep 2013 18:42:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VHiFT-0006rF-Vx for qemu-devel@nongnu.org; Thu, 05 Sep 2013 18:42:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43016) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VHiFT-0006rA-O8 for qemu-devel@nongnu.org; Thu, 05 Sep 2013 18:41:59 -0400 Message-ID: <1378420917.3246.271.camel@ul30vt.home> From: Alex Williamson Date: Thu, 05 Sep 2013 16:41:57 -0600 In-Reply-To: <522907AF.9040808@redhat.com> References: <20130905222853.4097.42724.stgit@bling.home> <522907AF.9040808@redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] vfio-pci: Cleanup error_reports List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: qemu-devel@nongnu.org, Anthony Liguori On Thu, 2013-09-05 at 16:37 -0600, Eric Blake wrote: > On 09/05/2013 04:29 PM, Alex Williamson wrote: > > Remove carriage returns and tweak formatting for error_reports. > > > > Signed-off-by: Alex Williamson > > --- > > hw/misc/vfio.c | 24 ++++++++++++------------ > > 1 file changed, 12 insertions(+), 12 deletions(-) > > > > diff --git a/hw/misc/vfio.c b/hw/misc/vfio.c > > index 730dec5..a73e7f5 100644 > > --- a/hw/misc/vfio.c > > +++ b/hw/misc/vfio.c > > @@ -3055,13 +3055,15 @@ static int vfio_get_device(VFIOGroup *group, const char *name, VFIODevice *vdev) > > ret = ioctl(vdev->fd, VFIO_DEVICE_GET_IRQ_INFO, &irq_info); > > if (ret) { > > /* This can fail for an old kernel or legacy PCI dev */ > > - DPRINTF("VFIO_DEVICE_GET_IRQ_INFO failure ret=%d\n", ret); > > + DPRINTF("VFIO_DEVICE_GET_IRQ_INFO failure: %m\n"); > > %m is a glibc extension, and does not exist on all platforms. You > should probably not make this change. It's not the only instance of %m in this file and, IIRC, was previously suggested by Anthony. Are we banning %m now? Thanks, Alex