From: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, armbru@redhat.com, lcapitulino@redhat.com,
stefanha@redhat.com, Wenchao Xia <xiawenc@linux.vnet.ibm.com>
Subject: [Qemu-devel] [PATCH V4 0/3] qemu-iotests: add test for fd passing via SCM rights
Date: Fri, 6 Sep 2013 11:24:31 +0800 [thread overview]
Message-ID: <1378437874-28103-1-git-send-email-xiawenc@linux.vnet.ibm.com> (raw)
This series add test case for fd passing with unix socket at runtime. Since
getfd and closefd interface will interact with monitor's data, so it will
help to do regression test for monitor patches. Since python2 do not support
sendmsg(), so a C helper program is added to do the job.
v2:
1: add missing $ in the makefile rule.
v3:
Address Eric's comments:
1: typo fix, remove "." in the end of error message, strick
check argc as "!=", use EXIT_SUCCESS and EXIT_FAILURE as exit
values, strict error check for strtol() call.
Address Luiz's comments:
1: change the helper program parameter as "bin < socket-fd > < file-path >",
the program open the file itself now, data parameter is removed and blank
is always used as iov data, better usage tip message, folder the string parsing
code into a function.
2: related change for helper program parameter change.
3: related change for helper program parameter change.
Other:
1: remove "LINK" rule in makefile, remove fd checking code inside send_fd()
since it is already checked before calling, add '' around %s for path and
number string in error message.
2: renamed fd_bin to bin in send_fd_scm() to tip better, add '' around %s
for path in error message.
v4:
Address Stefan's comments:
2: add space after # for comments, refined the comment's grammar.
3: add space after # for comments, refined the comment's grammar, add two
test cases for error path.
Wenchao Xia (3):
1 qemu-iotests: add unix socket help program
2 qemu-iotests: add infrastructure of fd passing via SCM
3 qemu-iotests: add tests for runtime fd passing via SCM rights
QMP/qmp.py | 6 ++
configure | 2 +-
tests/Makefile | 3 +-
tests/qemu-iotests/045 | 51 ++++++++++++-
tests/qemu-iotests/045.out | 4 +-
tests/qemu-iotests/check | 1 +
tests/qemu-iotests/iotests.py | 23 ++++++
tests/qemu-iotests/socket_scm_helper.c | 135 ++++++++++++++++++++++++++++++++
8 files changed, 220 insertions(+), 5 deletions(-)
create mode 100644 tests/qemu-iotests/socket_scm_helper.c
next reply other threads:[~2013-09-06 3:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-06 3:24 Wenchao Xia [this message]
2013-09-06 3:24 ` [Qemu-devel] [PATCH V4 1/3] qemu-iotests: add unix socket help program Wenchao Xia
2013-09-06 3:24 ` [Qemu-devel] [PATCH V4 2/3] qemu-iotests: add infrastructure of fd passing via SCM Wenchao Xia
2013-09-06 3:24 ` [Qemu-devel] [PATCH V4 3/3] qemu-iotests: add tests for runtime fd passing via SCM rights Wenchao Xia
2013-09-09 11:57 ` [Qemu-devel] [PATCH V4 0/3] qemu-iotests: add test for " Stefan Hajnoczi
2013-09-10 11:47 ` Kevin Wolf
2013-09-11 2:38 ` Wenchao Xia
2013-09-11 7:32 ` Kevin Wolf
2013-09-11 8:14 ` Wenchao Xia
2013-09-20 15:11 ` Stefan Hajnoczi
2013-09-22 6:43 ` Wenchao Xia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1378437874-28103-1-git-send-email-xiawenc@linux.vnet.ibm.com \
--to=xiawenc@linux.vnet.ibm.com \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).