qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <rth@twiddle.net>
To: qemu-devel@nongnu.org
Cc: aurelien@aurel32.net, Richard Henderson <rth@twiddle.net>
Subject: [Qemu-devel] [PATCH 08/19] tcg-ia64: Use SUB_A3 and ADDS_A4 for subtraction
Date: Thu,  5 Sep 2013 23:50:30 -0700	[thread overview]
Message-ID: <1378450242-27080-9-git-send-email-rth@twiddle.net> (raw)
In-Reply-To: <1378450242-27080-1-git-send-email-rth@twiddle.net>

We can subtract from more small constants that just 0 with one insn,
and we can add the negative for most small constants.

Signed-off-by: Richard Henderson <rth@twiddle.net>
---
 tcg/ia64/tcg-target.c | 25 +++++++++++++++++++++++--
 1 file changed, 23 insertions(+), 2 deletions(-)

diff --git a/tcg/ia64/tcg-target.c b/tcg/ia64/tcg-target.c
index 1659421..cc8c7a9 100644
--- a/tcg/ia64/tcg-target.c
+++ b/tcg/ia64/tcg-target.c
@@ -1078,6 +1078,28 @@ static inline void tcg_out_add(TCGContext *s, TCGReg ret, TCGReg arg1,
     }
 }
 
+static inline void tcg_out_sub(TCGContext *s, TCGReg ret, TCGArg arg1,
+                               int const_arg1, TCGArg arg2, int const_arg2)
+{
+    if (const_arg1 && arg1 == (int8_t)arg1) {
+        if (const_arg2) {
+            tcg_out_movi(s, TCG_TYPE_I64, ret, arg1 - arg2);
+            return;
+        }
+        tcg_out_bundle(s, mmI,
+                       INSN_NOP_M,
+                       INSN_NOP_M,
+                       tcg_opc_a3(TCG_REG_P0, OPC_SUB_A3, ret, arg1, arg2));
+    } else if (const_arg2 && -arg2 == sextract64(-arg2, 0, 14)) {
+        tcg_out_bundle(s, mmI,
+                       INSN_NOP_M,
+                       INSN_NOP_M,
+                       tcg_opc_a4(TCG_REG_P0, OPC_ADDS_A4, ret, -arg2, arg1));
+    } else {
+        tcg_out_alu(s, OPC_SUB_A1, ret, arg1, 0, arg2, 0);
+    }
+}
+
 static inline void tcg_out_eqv(TCGContext *s, TCGArg ret,
                                TCGArg arg1, int const_arg1,
                                TCGArg arg2, int const_arg2)
@@ -2083,8 +2105,7 @@ static inline void tcg_out_op(TCGContext *s, TCGOpcode opc,
         break;
     case INDEX_op_sub_i32:
     case INDEX_op_sub_i64:
-        tcg_out_alu(s, OPC_SUB_A1, args[0], args[1], const_args[1],
-                    args[2], const_args[2]);
+        tcg_out_sub(s, args[0], args[1], const_args[1], args[2], const_args[2]);
         break;
 
     case INDEX_op_and_i32:
-- 
1.8.3.1

  parent reply	other threads:[~2013-09-06  6:51 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-06  6:50 [Qemu-devel] [PATCH 00/19] tcg-ia64 fixes and improvements Richard Henderson
2013-09-06  6:50 ` [Qemu-devel] [PATCH 01/19] tcg-ia64: Use TCGMemOp within qemu_ldst routines Richard Henderson
2013-09-06  6:50 ` [Qemu-devel] [PATCH 02/19] tcg-ia64: Use shortcuts for nop insns Richard Henderson
2013-09-06  6:50 ` [Qemu-devel] [PATCH 03/19] tcg-ia64: Handle constant calls Richard Henderson
2013-09-06  6:50 ` [Qemu-devel] [PATCH 04/19] tcg-ia64: Simplify brcond Richard Henderson
2013-09-06  6:50 ` [Qemu-devel] [PATCH 05/19] tcg-ia64: Move AREG0 to R32 Richard Henderson
2013-09-06  6:50 ` [Qemu-devel] [PATCH 06/19] tcg-ia64: Avoid unnecessary stop bit in tcg_out_alu Richard Henderson
2013-09-06  6:50 ` [Qemu-devel] [PATCH 07/19] tcg-ia64: Use ADDS for small addition Richard Henderson
2013-09-06  6:50 ` Richard Henderson [this message]
2013-09-06  6:50 ` [Qemu-devel] [PATCH 09/19] tcg-ia64: Use A3 form of logical operations Richard Henderson
2013-09-06  6:50 ` [Qemu-devel] [PATCH 10/19] tcg-ia64 Introduce tcg_opc_mov_a Richard Henderson
2013-09-06  6:50 ` [Qemu-devel] [PATCH 11/19] tcg-ia64 Introduce tcg_opc_movi_a Richard Henderson
2013-09-06  6:50 ` [Qemu-devel] [PATCH 12/19] tcg-ia64 Introduce tcg_opc_ext_i Richard Henderson
2013-09-06  6:50 ` [Qemu-devel] [PATCH 13/19] tcg-ia64 Introduce tcg_opc_bswap64_i Richard Henderson
2013-09-06  6:50 ` [Qemu-devel] [PATCH 14/19] tcg-ia64: Re-bundle the tlb load Richard Henderson
2013-09-06  6:50 ` [Qemu-devel] [PATCH 15/19] tcg-ia64: Move bswap for store into " Richard Henderson
2013-09-06  6:50 ` [Qemu-devel] [PATCH 16/19] tcg-ia64: Move tlb addend load into tlb read Richard Henderson
2013-09-06  6:50 ` [Qemu-devel] [PATCH 17/19] tcg-i64: Reduce code duplication in tcg_out_qemu_ld Richard Henderson
2013-09-06  6:50 ` [Qemu-devel] [PATCH 18/19] tcg-ia64: Convert to new ldst helpers Richard Henderson
2013-09-06  6:50 ` [Qemu-devel] [PATCH 19/19] tcg-ia64: Move part of softmmu slow path out of line Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1378450242-27080-9-git-send-email-rth@twiddle.net \
    --to=rth@twiddle.net \
    --cc=aurelien@aurel32.net \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).