From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39312)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1VHqQM-0006pM-Un
	for qemu-devel@nongnu.org; Fri, 06 Sep 2013 03:25:52 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1VHqQG-0007L2-AE
	for qemu-devel@nongnu.org; Fri, 06 Sep 2013 03:25:46 -0400
Received: from mx1.redhat.com ([209.132.183.28]:40848)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1VHqQF-0007Kw-N6
	for qemu-devel@nongnu.org; Fri, 06 Sep 2013 03:25:39 -0400
Message-ID: <1378452326.13048.7.camel@nilsson.home.kraxel.org>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Fri, 06 Sep 2013 09:25:26 +0200
In-Reply-To: <1378419871-31895-3-git-send-email-bsd@redhat.com>
References: <1378419871-31895-1-git-send-email-bsd@redhat.com>
	<1378419871-31895-3-git-send-email-bsd@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 2/3] hda-codec: make mixemu selectable
	at runtime
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Bandan Das <bsd@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, "Vassili Karpov (malc)" <av1474@comtv.ru>, qemu-devel@nongnu.org, Jan Kiszka <jan.kiszka@siemens.com>, Markus Armbruster <armbru@redhat.com>

> --- a/hw/audio/hda-codec.c
> +++ b/hw/audio/hda-codec.c
> @@ -118,7 +118,20 @@ static void hda_codec_parse_fmt(uint32_t format, struct audsettings *as)
>  #define QEMU_HDA_AMP_NONE    (0)
>  #define QEMU_HDA_AMP_STEPS   0x4a
>  
> +#ifdef CONFIG_MIXEMU
> +#define   PARAM mixemu
> +#define   HDA_MIXER
>  #include "hda-codec-common.h"
> +#else
> +/* keep the compiler quiet */
> +static const desc_codec output_mixemu;
> +static const desc_codec duplex_mixemu;
> +static const desc_codec micro_mixemu;

Needed?  The *_mixemu variants are not referenced without CONFIG_MIXEMU

> +#endif
> +
> +#define   PARAM nomixemu

#undefine HDA_MIXER

> +#include  "hda-codec-common.h"
> +

cheers,
  Gerd