From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40305) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VHy8W-0004kN-Gi for qemu-devel@nongnu.org; Fri, 06 Sep 2013 11:39:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VHy8Q-0005AM-Hh for qemu-devel@nongnu.org; Fri, 06 Sep 2013 11:39:52 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54084) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VHy8Q-0005AA-AQ for qemu-devel@nongnu.org; Fri, 06 Sep 2013 11:39:46 -0400 From: Stefan Hajnoczi Date: Fri, 6 Sep 2013 17:38:41 +0200 Message-Id: <1378481953-23099-11-git-send-email-stefanha@redhat.com> In-Reply-To: <1378481953-23099-1-git-send-email-stefanha@redhat.com> References: <1378481953-23099-1-git-send-email-stefanha@redhat.com> Subject: [Qemu-devel] [PULL 10/42] vvfat: use bdrv_new() to allocate BlockDriverState List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Fam Zheng , Stefan Hajnoczi , Anthony Liguori From: Fam Zheng we need bdrv_new() to properly initialize BDS, don't allocate memory manually. Signed-off-by: Fam Zheng Signed-off-by: Stefan Hajnoczi --- block/vvfat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/vvfat.c b/block/vvfat.c index cd3b8ed..a827d91 100644 --- a/block/vvfat.c +++ b/block/vvfat.c @@ -2943,7 +2943,7 @@ static int enable_write_target(BDRVVVFATState *s) unlink(s->qcow_filename); #endif - s->bs->backing_hd = calloc(sizeof(BlockDriverState), 1); + s->bs->backing_hd = bdrv_new(""); s->bs->backing_hd->drv = &vvfat_write_target; s->bs->backing_hd->opaque = g_malloc(sizeof(void*)); *(void**)s->bs->backing_hd->opaque = s; -- 1.8.3.1