From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40547) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VHy98-0005eD-Om for qemu-devel@nongnu.org; Fri, 06 Sep 2013 11:40:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VHy92-0005Yr-Qa for qemu-devel@nongnu.org; Fri, 06 Sep 2013 11:40:30 -0400 Received: from mx1.redhat.com ([209.132.183.28]:29806) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VHy8z-0005YY-DV for qemu-devel@nongnu.org; Fri, 06 Sep 2013 11:40:24 -0400 From: Stefan Hajnoczi Date: Fri, 6 Sep 2013 17:38:52 +0200 Message-Id: <1378481953-23099-22-git-send-email-stefanha@redhat.com> In-Reply-To: <1378481953-23099-1-git-send-email-stefanha@redhat.com> References: <1378481953-23099-1-git-send-email-stefanha@redhat.com> Subject: [Qemu-devel] [PULL 21/42] cow: do not call bdrv_co_is_allocated List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Stefan Hajnoczi , Anthony Liguori From: Paolo Bonzini As we change bdrv_is_allocated to gather more information from bs and bs->file, it will become a bit slower. It is still appropriate for online jobs, but not for reads/writes. Call the internal function instead. Reviewed-by: Eric Blake Signed-off-by: Paolo Bonzini Signed-off-by: Stefan Hajnoczi --- block/cow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/cow.c b/block/cow.c index cd889e6..f4eca10 100644 --- a/block/cow.c +++ b/block/cow.c @@ -212,7 +212,7 @@ static int coroutine_fn cow_read(BlockDriverState *bs, int64_t sector_num, int ret, n; while (nb_sectors > 0) { - if (bdrv_co_is_allocated(bs, sector_num, nb_sectors, &n)) { + if (cow_co_is_allocated(bs, sector_num, nb_sectors, &n)) { ret = bdrv_pread(bs->file, s->cow_sectors_offset + sector_num * 512, buf, n * 512); -- 1.8.3.1