From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40588) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VHy9D-0005eK-JL for qemu-devel@nongnu.org; Fri, 06 Sep 2013 11:40:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VHy93-0005ZB-6m for qemu-devel@nongnu.org; Fri, 06 Sep 2013 11:40:35 -0400 Received: from mx1.redhat.com ([209.132.183.28]:19379) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VHy92-0005Yg-V2 for qemu-devel@nongnu.org; Fri, 06 Sep 2013 11:40:25 -0400 From: Stefan Hajnoczi Date: Fri, 6 Sep 2013 17:38:53 +0200 Message-Id: <1378481953-23099-23-git-send-email-stefanha@redhat.com> In-Reply-To: <1378481953-23099-1-git-send-email-stefanha@redhat.com> References: <1378481953-23099-1-git-send-email-stefanha@redhat.com> Subject: [Qemu-devel] [PULL 22/42] block: keep bs->total_sectors up to date even for growable block devices List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Stefan Hajnoczi , Anthony Liguori From: Paolo Bonzini If a BlockDriverState is growable, after every write we need to check if bs->total_sectors might have changed. With this change, bdrv_getlength does not need anymore a system call. Signed-off-by: Paolo Bonzini Signed-off-by: Stefan Hajnoczi --- block.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/block.c b/block.c index 905bf34..d9a3a7f 100644 --- a/block.c +++ b/block.c @@ -2739,6 +2739,9 @@ static int coroutine_fn bdrv_co_do_writev(BlockDriverState *bs, if (bs->wr_highest_sector < sector_num + nb_sectors - 1) { bs->wr_highest_sector = sector_num + nb_sectors - 1; } + if (bs->growable && ret >= 0) { + bs->total_sectors = MAX(bs->total_sectors, sector_num + nb_sectors); + } tracked_request_end(&req); @@ -2813,7 +2816,7 @@ int64_t bdrv_getlength(BlockDriverState *bs) if (!drv) return -ENOMEDIUM; - if (bs->growable || bdrv_dev_has_removable_media(bs)) { + if (bdrv_dev_has_removable_media(bs)) { if (drv->bdrv_getlength) { return drv->bdrv_getlength(bs); } -- 1.8.3.1