From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47940) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VIrgP-0005Uy-CR for qemu-devel@nongnu.org; Sun, 08 Sep 2013 22:58:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VIrgC-0000i7-H9 for qemu-devel@nongnu.org; Sun, 08 Sep 2013 22:58:33 -0400 Received: from e28smtp09.in.ibm.com ([122.248.162.9]:46479) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VIrgB-0000hU-Vh for qemu-devel@nongnu.org; Sun, 08 Sep 2013 22:58:20 -0400 Received: from /spool/local by e28smtp09.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 9 Sep 2013 08:21:55 +0530 Received: from d28relay03.in.ibm.com (d28relay03.in.ibm.com [9.184.220.60]) by d28dlp02.in.ibm.com (Postfix) with ESMTP id 8C2FC394004E for ; Mon, 9 Sep 2013 08:27:59 +0530 (IST) Received: from d28av02.in.ibm.com (d28av02.in.ibm.com [9.184.220.64]) by d28relay03.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r89302rc41877692 for ; Mon, 9 Sep 2013 08:30:05 +0530 Received: from d28av02.in.ibm.com (localhost [127.0.0.1]) by d28av02.in.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id r892w8ae007845 for ; Mon, 9 Sep 2013 08:28:08 +0530 From: Wenchao Xia Date: Mon, 9 Sep 2013 10:57:55 +0800 Message-Id: <1378695482-29805-1-git-send-email-xiawenc@linux.vnet.ibm.com> Subject: [Qemu-devel] [PATCH V3 0/7] qcow2: rollback the modification on fail in snapshot creation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, pbonzini@redhat.com, mreitz@redhat.com, Wenchao Xia , stefanha@gmail.com V2: 1: all fail case will goto fail section. 2: add the goto code. v3: Address Stefan's comments: 2: don't goto fail after allocation failure. 3: use sn->l1size correctly in qcow2_free_cluster(). 4-7: add test case to verify the error paths. Other: 1: new patch fix a existing bug, which will be exposed in error path test. Wenchao Xia (7): 1 qcow2: restore nb_snapshots when fail in snapshot creation 2 qcow2: free allocated cluster on fail in qcow2_write_snapshots() 3 qcow2: cancel the modification on fail in qcow2_snapshot_create() 4 blkdebug: add debug events for snapshot 5 qcow2: use debug events for snapshot 6 qcow2: print message for error path in snapshot creation 7 qemu-iotests: add test for qcow2 snapshot block/blkdebug.c | 4 + block/qcow2-snapshot.c | 80 ++++++++++++++-- include/block/block.h | 4 + tests/qemu-iotests/063 | 229 ++++++++++++++++++++++++++++++++++++++++++++ tests/qemu-iotests/063.out | 37 +++++++ tests/qemu-iotests/group | 1 + 6 files changed, 348 insertions(+), 7 deletions(-) create mode 100755 tests/qemu-iotests/063 create mode 100644 tests/qemu-iotests/063.out