From: Michael Roth <mdroth@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, tomoki.sekiyama@hds.com
Subject: [Qemu-devel] [PATCH 10/10] QMP/qemu-ga-client: Make timeout longer for guest-fsfreeze-freeze command
Date: Mon, 9 Sep 2013 14:41:41 -0500 [thread overview]
Message-ID: <1378755701-2051-11-git-send-email-mdroth@linux.vnet.ibm.com> (raw)
In-Reply-To: <1378755701-2051-1-git-send-email-mdroth@linux.vnet.ibm.com>
From: Tomoki Sekiyama <tomoki.sekiyama@hds.com>
guest-fsfreeze-freeze command can take longer than 3 seconds when heavy
disk I/O is running. To avoid unexpected timeout, this changes the timeout
to 60 seconds (timeout of pre-commit phase of VSS).
Signed-off-by: Tomoki Sekiyama <tomoki.sekiyama@hds.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Michael Roth <mdroth@linux.vnet.ibm.com>
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
---
QMP/qemu-ga-client | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/QMP/qemu-ga-client b/QMP/qemu-ga-client
index 46676c3..b5f7e7c 100755
--- a/QMP/qemu-ga-client
+++ b/QMP/qemu-ga-client
@@ -267,7 +267,9 @@ def main(address, cmd, args):
print('Hint: qemu is not running?')
sys.exit(1)
- if cmd != 'ping':
+ if cmd == 'fsfreeze' and args[0] == 'freeze':
+ client.sync(60)
+ elif cmd != 'ping':
client.sync()
globals()['_cmd_' + cmd](client, args)
--
1.7.9.5
prev parent reply other threads:[~2013-09-09 19:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-09 19:41 [Qemu-devel] [PULL] qemu-ga: VSS/fsfreeze support for Win32 Michael Roth
2013-09-09 19:41 ` [Qemu-devel] [PATCH 01/10] configure: Support configuring C++ compiler Michael Roth
2013-09-09 19:41 ` [Qemu-devel] [PATCH 02/10] Add c++ keywords to QAPI helper script Michael Roth
2013-09-09 19:41 ` [Qemu-devel] [PATCH 03/10] checkpatch.pl: Check .cpp files Michael Roth
2013-09-09 19:41 ` [Qemu-devel] [PATCH 04/10] Add a script to extract VSS SDK headers on POSIX system Michael Roth
2013-09-09 19:41 ` [Qemu-devel] [PATCH 05/10] qemu-ga: Add configure options to specify path to Windows/VSS SDK Michael Roth
2013-09-09 19:41 ` [Qemu-devel] [PATCH 06/10] error: Add error_set_win32 and error_setg_win32 Michael Roth
2013-09-09 19:41 ` [Qemu-devel] [PATCH 07/10] qemu-ga: Add Windows VSS provider and requester as DLL Michael Roth
2013-09-09 19:41 ` [Qemu-devel] [PATCH 08/10] qemu-ga: Call Windows VSS requester in fsfreeze command handler Michael Roth
2013-09-09 19:41 ` [Qemu-devel] [PATCH 09/10] qemu-ga: Install Windows VSS provider on `qemu-ga -s install' Michael Roth
2013-09-09 19:41 ` Michael Roth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1378755701-2051-11-git-send-email-mdroth@linux.vnet.ibm.com \
--to=mdroth@linux.vnet.ibm.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=tomoki.sekiyama@hds.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).