qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [Qemu-devel] [PULL] QMP queue
@ 2013-06-28 20:43 Luiz Capitulino
  2013-07-10 16:53 ` Anthony Liguori
  0 siblings, 1 reply; 6+ messages in thread
From: Luiz Capitulino @ 2013-06-28 20:43 UTC (permalink / raw)
  To: qemu-devel; +Cc: aliguori

The following changes since commit 36125631e79d53ffb9365740f43f386e2171d116:

  Merge remote-tracking branch 'kwolf/for-anthony' into staging (2013-06-28 10:37:34 -0500)

are available in the git repository at:


  git://repo.or.cz/qemu/qmp-unstable.git queue/qmp

for you to fetch changes up to fbe2e26c15af35e4d157874dc80f6a19eebaa83b:

  hmp: Make "info block" output more readable (2013-06-28 16:14:39 -0400)

----------------------------------------------------------------
Kevin Wolf (1):
      hmp: Make "info block" output more readable

 hmp.c | 94 +++++++++++++++++++++++++++++++++++++++----------------------------
 1 file changed, 55 insertions(+), 39 deletions(-)

-- 
1.8.1.4

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [Qemu-devel] [PULL] QMP queue
  2013-06-28 20:43 Luiz Capitulino
@ 2013-07-10 16:53 ` Anthony Liguori
  0 siblings, 0 replies; 6+ messages in thread
From: Anthony Liguori @ 2013-07-10 16:53 UTC (permalink / raw)
  To: Luiz Capitulino, qemu-devel; +Cc: aliguori

Pulled.  Thanks.

Regards,

Anthony Liguori

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Qemu-devel] [PULL] QMP queue
@ 2013-09-10 14:12 Luiz Capitulino
  2013-09-10 14:12 ` [Qemu-devel] [PULL] qapi-types.py: Fix enum struct sizes on i686 Luiz Capitulino
  0 siblings, 1 reply; 6+ messages in thread
From: Luiz Capitulino @ 2013-09-10 14:12 UTC (permalink / raw)
  To: anthony; +Cc: qemu-devel

The changes (since 94c2b6aff43cdfcfdfb552773a6b6b973a72ef0b) are available
in the following repository:

    git://repo.or.cz/qemu/qmp-unstable.git queue/qmp

Cole Robinson (1):
  qapi-types.py: Fix enum struct sizes on i686

 scripts/qapi-types.py | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

-- 
1.8.1.4

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Qemu-devel] [PULL] qapi-types.py: Fix enum struct sizes on i686
  2013-09-10 14:12 [Qemu-devel] [PULL] QMP queue Luiz Capitulino
@ 2013-09-10 14:12 ` Luiz Capitulino
  0 siblings, 0 replies; 6+ messages in thread
From: Luiz Capitulino @ 2013-09-10 14:12 UTC (permalink / raw)
  To: anthony; +Cc: qemu-devel

From: Cole Robinson <crobinso@redhat.com>

Unlike other list types, enum wasn't adding any padding, which caused
a mismatch between the generated struct size and GenericList struct
size. More details in a678e26cbe89f7a27cbce794c2c2784571ee9d21

This crashed qemu if calling qmp query-tpm-types for example, which
upsets libvirt capabilities probing. Reproducer on i686:

(sleep 5; printf '{"execute":"qmp_capabilities"}\n{"execute":"query-tpm-types"}\n') | ./i386-softmmu/qemu-system-i386 -S -nodefaults -nographic -M none -qmp stdio

https://bugs.launchpad.net/qemu/+bug/1219207

Cc: qemu-stable@nongnu.org
Signed-off-by: Cole Robinson <crobinso@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Tested-by: Richard W.M. Jones <rjones@redhat.com>
Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
---
 scripts/qapi-types.py | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/scripts/qapi-types.py b/scripts/qapi-types.py
index 86de980..5222463 100644
--- a/scripts/qapi-types.py
+++ b/scripts/qapi-types.py
@@ -51,7 +51,10 @@ def generate_fwd_enum_struct(name, members):
     return mcgen('''
 typedef struct %(name)sList
 {
-    %(name)s value;
+    union {
+        %(name)s value;
+        uint64_t padding;
+    };
     struct %(name)sList *next;
 } %(name)sList;
 ''',
-- 
1.8.1.4

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [Qemu-devel] [PULL] QMP queue
@ 2013-10-18 18:30 Luiz Capitulino
  2013-10-29 21:30 ` Luiz Capitulino
  0 siblings, 1 reply; 6+ messages in thread
From: Luiz Capitulino @ 2013-10-18 18:30 UTC (permalink / raw)
  To: anthony; +Cc: qemu-devel

The following changes since commit fc8ead74674b7129e8f31c2595c76658e5622197:

  Merge remote-tracking branch 'qemu-kvm/uq/master' into staging (2013-10-18 10:03:24 -0700)

are available in the git repository at:


  git://repo.or.cz/qemu/qmp-unstable.git queue/qmp

for you to fetch changes up to c20b7fa4b2fedd979bcb0cc974bb5d08a10e3448:

  monitor: eliminate monitor_event_state_lock (2013-10-18 14:23:00 -0400)

----------------------------------------------------------------
Paolo Bonzini (1):
      monitor: eliminate monitor_event_state_lock

 monitor.c | 6 ------
 1 file changed, 6 deletions(-)

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [Qemu-devel] [PULL] QMP queue
  2013-10-18 18:30 [Qemu-devel] [PULL] QMP queue Luiz Capitulino
@ 2013-10-29 21:30 ` Luiz Capitulino
  0 siblings, 0 replies; 6+ messages in thread
From: Luiz Capitulino @ 2013-10-29 21:30 UTC (permalink / raw)
  To: anthony; +Cc: qemu-devel

On Fri, 18 Oct 2013 14:30:02 -0400
Luiz Capitulino <lcapitulino@redhat.com> wrote:

> The following changes since commit fc8ead74674b7129e8f31c2595c76658e5622197:
> 
>   Merge remote-tracking branch 'qemu-kvm/uq/master' into staging (2013-10-18 10:03:24 -0700)
> 
> are available in the git repository at:
> 
> 
>   git://repo.or.cz/qemu/qmp-unstable.git queue/qmp
> 
> for you to fetch changes up to c20b7fa4b2fedd979bcb0cc974bb5d08a10e3448:
> 
>   monitor: eliminate monitor_event_state_lock (2013-10-18 14:23:00 -0400)
> 
> ----------------------------------------------------------------
> Paolo Bonzini (1):
>       monitor: eliminate monitor_event_state_lock
> 
>  monitor.c | 6 ------
>  1 file changed, 6 deletions(-)
> 

This for 1.7.

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2013-10-29 21:30 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-10 14:12 [Qemu-devel] [PULL] QMP queue Luiz Capitulino
2013-09-10 14:12 ` [Qemu-devel] [PULL] qapi-types.py: Fix enum struct sizes on i686 Luiz Capitulino
  -- strict thread matches above, loose matches on Subject: below --
2013-10-18 18:30 [Qemu-devel] [PULL] QMP queue Luiz Capitulino
2013-10-29 21:30 ` Luiz Capitulino
2013-06-28 20:43 Luiz Capitulino
2013-07-10 16:53 ` Anthony Liguori

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).