qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PULL 12/28] target-arm: Pass DisasContext* to gen_set_pc_im()
Date: Tue, 10 Sep 2013 19:52:06 +0100	[thread overview]
Message-ID: <1378839142-7726-13-git-send-email-peter.maydell@linaro.org> (raw)
In-Reply-To: <1378839142-7726-1-git-send-email-peter.maydell@linaro.org>

We want gen_set_pc_im() to work for both AArch64 and AArch32, but
to do this we'll need the DisasContext* so we can tell which mode
we're in, so pass it in as a parameter.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Message-id: 1378235544-22290-7-git-send-email-peter.maydell@linaro.org
---
 target-arm/translate.c |   26 +++++++++++++-------------
 1 file changed, 13 insertions(+), 13 deletions(-)

diff --git a/target-arm/translate.c b/target-arm/translate.c
index ca411b3..2d8e0a5 100644
--- a/target-arm/translate.c
+++ b/target-arm/translate.c
@@ -905,7 +905,7 @@ DO_GEN_ST(st8)
 DO_GEN_ST(st16)
 DO_GEN_ST(st32)
 
-static inline void gen_set_pc_im(target_ulong val)
+static inline void gen_set_pc_im(DisasContext *s, target_ulong val)
 {
     tcg_gen_movi_i32(cpu_R[15], val);
 }
@@ -3420,10 +3420,10 @@ static inline void gen_goto_tb(DisasContext *s, int n, target_ulong dest)
     tb = s->tb;
     if ((tb->pc & TARGET_PAGE_MASK) == (dest & TARGET_PAGE_MASK)) {
         tcg_gen_goto_tb(n);
-        gen_set_pc_im(dest);
+        gen_set_pc_im(s, dest);
         tcg_gen_exit_tb((uintptr_t)tb + n);
     } else {
-        gen_set_pc_im(dest);
+        gen_set_pc_im(s, dest);
         tcg_gen_exit_tb(0);
     }
 }
@@ -3552,7 +3552,7 @@ gen_set_condexec (DisasContext *s)
 static void gen_exception_insn(DisasContext *s, int offset, int excp)
 {
     gen_set_condexec(s);
-    gen_set_pc_im(s->pc - offset);
+    gen_set_pc_im(s, s->pc - offset);
     gen_exception(excp);
     s->is_jmp = DISAS_JUMP;
 }
@@ -3561,7 +3561,7 @@ static void gen_nop_hint(DisasContext *s, int val)
 {
     switch (val) {
     case 3: /* wfi */
-        gen_set_pc_im(s->pc);
+        gen_set_pc_im(s, s->pc);
         s->is_jmp = DISAS_WFI;
         break;
     case 2: /* wfe */
@@ -6338,7 +6338,7 @@ static int disas_coproc_insn(CPUARMState * env, DisasContext *s, uint32_t insn)
             if (isread) {
                 return 1;
             }
-            gen_set_pc_im(s->pc);
+            gen_set_pc_im(s, s->pc);
             s->is_jmp = DISAS_WFI;
             return 0;
         default:
@@ -6358,7 +6358,7 @@ static int disas_coproc_insn(CPUARMState * env, DisasContext *s, uint32_t insn)
                     tmp64 = tcg_const_i64(ri->resetvalue);
                 } else if (ri->readfn) {
                     TCGv_ptr tmpptr;
-                    gen_set_pc_im(s->pc);
+                    gen_set_pc_im(s, s->pc);
                     tmp64 = tcg_temp_new_i64();
                     tmpptr = tcg_const_ptr(ri);
                     gen_helper_get_cp_reg64(tmp64, cpu_env, tmpptr);
@@ -6381,7 +6381,7 @@ static int disas_coproc_insn(CPUARMState * env, DisasContext *s, uint32_t insn)
                     tmp = tcg_const_i32(ri->resetvalue);
                 } else if (ri->readfn) {
                     TCGv_ptr tmpptr;
-                    gen_set_pc_im(s->pc);
+                    gen_set_pc_im(s, s->pc);
                     tmp = tcg_temp_new_i32();
                     tmpptr = tcg_const_ptr(ri);
                     gen_helper_get_cp_reg(tmp, cpu_env, tmpptr);
@@ -6416,7 +6416,7 @@ static int disas_coproc_insn(CPUARMState * env, DisasContext *s, uint32_t insn)
                 tcg_temp_free_i32(tmphi);
                 if (ri->writefn) {
                     TCGv_ptr tmpptr = tcg_const_ptr(ri);
-                    gen_set_pc_im(s->pc);
+                    gen_set_pc_im(s, s->pc);
                     gen_helper_set_cp_reg64(cpu_env, tmpptr, tmp64);
                     tcg_temp_free_ptr(tmpptr);
                 } else {
@@ -6427,7 +6427,7 @@ static int disas_coproc_insn(CPUARMState * env, DisasContext *s, uint32_t insn)
                 if (ri->writefn) {
                     TCGv_i32 tmp;
                     TCGv_ptr tmpptr;
-                    gen_set_pc_im(s->pc);
+                    gen_set_pc_im(s, s->pc);
                     tmp = load_reg(s, rt);
                     tmpptr = tcg_const_ptr(ri);
                     gen_helper_set_cp_reg(cpu_env, tmpptr, tmp);
@@ -8036,7 +8036,7 @@ static void disas_arm_insn(CPUARMState * env, DisasContext *s)
             break;
         case 0xf:
             /* swi */
-            gen_set_pc_im(s->pc);
+            gen_set_pc_im(s, s->pc);
             s->is_jmp = DISAS_SWI;
             break;
         default:
@@ -9940,7 +9940,7 @@ static void disas_thumb_insn(CPUARMState *env, DisasContext *s)
 
         if (cond == 0xf) {
             /* swi */
-            gen_set_pc_im(s->pc);
+            gen_set_pc_im(s, s->pc);
             s->is_jmp = DISAS_SWI;
             break;
         }
@@ -10190,7 +10190,7 @@ static inline void gen_intermediate_code_internal(ARMCPU *cpu,
             gen_set_label(dc->condlabel);
         }
         if (dc->condjmp || !dc->is_jmp) {
-            gen_set_pc_im(dc->pc);
+            gen_set_pc_im(dc, dc->pc);
             dc->condjmp = 0;
         }
         gen_set_condexec(dc);
-- 
1.7.9.5

  parent reply	other threads:[~2013-09-10 18:52 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-10 18:51 [Qemu-devel] [PULL 00/28] target-arm queue Peter Maydell
2013-09-10 18:51 ` [Qemu-devel] [PULL 01/28] target-arm: Make '-cpu any' available in linux-user mode only Peter Maydell
2013-09-10 18:51 ` [Qemu-devel] [PULL 02/28] target-arm: Use sextract32() in branch decode Peter Maydell
2013-09-10 18:51 ` [Qemu-devel] [PULL 03/28] target-arm: Avoid "1 << 31" undefined behaviour Peter Maydell
2013-09-10 18:51 ` [Qemu-devel] [PULL 04/28] target-arm: fix ARMv7M stack alignment on reset Peter Maydell
2013-09-10 18:51 ` [Qemu-devel] [PULL 05/28] target-arm: Implement qmp query-cpu-definitions Peter Maydell
2013-09-10 18:52 ` [Qemu-devel] [PULL 06/28] pl110: Clarify comment about PL110 ID on VersatilePB Peter Maydell
2013-09-10 18:52 ` [Qemu-devel] [PULL 07/28] abitypes.h: Remove incorrect ARM ABI_LLONG_ALIGNMENT Peter Maydell
2013-09-10 18:52 ` [Qemu-devel] [PULL 08/28] target-arm: Abstract out load/store from a vaddr in AArch32 Peter Maydell
2013-09-10 18:52 ` [Qemu-devel] [PULL 09/28] target-arm: Extract the disas struct to a header file Peter Maydell
2013-09-10 18:52 ` [Qemu-devel] [PULL 10/28] target-arm: Export cpu_env Peter Maydell
2013-09-10 18:52 ` [Qemu-devel] [PULL 11/28] target-arm: Fix target_ulong/uint32_t confusions Peter Maydell
2013-09-10 18:52 ` Peter Maydell [this message]
2013-09-10 18:52 ` [Qemu-devel] [PULL 13/28] target-arm: Add new AArch64CPUInfo base class and subclasses Peter Maydell
2013-09-10 18:52 ` [Qemu-devel] [PULL 14/28] target-arm: Disable 32 bit CPUs in 64 bit linux-user builds Peter Maydell
2013-09-10 18:52 ` [Qemu-devel] [PULL 15/28] target-arm: Prepare translation for AArch64 code Peter Maydell
2013-09-10 18:52 ` [Qemu-devel] [PULL 16/28] target-arm: Add AArch64 translation stub Peter Maydell
2013-09-10 18:52 ` [Qemu-devel] [PULL 17/28] target-arm: Add AArch64 gdbstub support Peter Maydell
2013-09-10 18:52 ` [Qemu-devel] [PULL 18/28] linux-user: Don't treat AArch64 cpu names specially Peter Maydell
2013-09-10 18:52 ` [Qemu-devel] [PULL 19/28] linux-user: Add cpu loop for AArch64 Peter Maydell
2013-09-10 18:52 ` [Qemu-devel] [PULL 20/28] linux-user: Add syscall number definitions " Peter Maydell
2013-09-10 18:52 ` [Qemu-devel] [PULL 21/28] linux-user: Fix up AArch64 syscall handlers Peter Maydell
2013-09-10 18:52 ` [Qemu-devel] [PULL 22/28] linux-user: Add signal handling for AArch64 Peter Maydell
2013-09-10 18:52 ` [Qemu-devel] [PULL 23/28] linux-user: Make sure NWFPE code is 32 bit ARM only Peter Maydell
2013-09-10 18:52 ` [Qemu-devel] [PULL 24/28] linux-user: Implement cpu_set_tls() and cpu_clone_regs() for AArch64 Peter Maydell
2013-09-10 18:52 ` [Qemu-devel] [PULL 25/28] linux-user: Add AArch64 termbits.h definitions Peter Maydell
2013-09-10 18:52 ` [Qemu-devel] [PULL 26/28] linux-user: Allow targets to specify a minimum uname release Peter Maydell
2013-09-10 18:52 ` [Qemu-devel] [PULL 27/28] linux-user: Add AArch64 support Peter Maydell
2013-09-10 18:52 ` [Qemu-devel] [PULL 28/28] configure: Add handling code for AArch64 targets Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1378839142-7726-13-git-send-email-peter.maydell@linaro.org \
    --to=peter.maydell@linaro.org \
    --cc=anthony@codemonkey.ws \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).