From: Peter Maydell <peter.maydell@linaro.org>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PULL 21/28] linux-user: Fix up AArch64 syscall handlers
Date: Tue, 10 Sep 2013 19:52:15 +0100 [thread overview]
Message-ID: <1378839142-7726-22-git-send-email-peter.maydell@linaro.org> (raw)
In-Reply-To: <1378839142-7726-1-git-send-email-peter.maydell@linaro.org>
From: Alexander Graf <agraf@suse.de>
Some syscall handlers have special code for ARM enabled that we don't
need on AArch64. Exclude AArch64 in those cases. In other places we
can share struct definitions with other targets or have to provide our
own.
With this patch applied, most syscall definitions in linux-user should
be sound for AArch64.
Signed-off-by: Alexander Graf <agraf@suse.de>
Signed-off-by: John Rigby <john.rigby@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Message-id: 1378235544-22290-16-git-send-email-peter.maydell@linaro.org
Message-id: 1368505980-17151-9-git-send-email-john.rigby@linaro.org
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
linux-user/syscall.c | 5 +++--
linux-user/syscall_defs.h | 28 ++++++++++++++++++++++++++--
2 files changed, 29 insertions(+), 4 deletions(-)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index ecead51..ea04db1 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -4737,7 +4737,7 @@ static inline abi_long host_to_target_stat64(void *cpu_env,
abi_ulong target_addr,
struct stat *host_st)
{
-#ifdef TARGET_ARM
+#if defined(TARGET_ARM) && defined(TARGET_ABI32)
if (((CPUARMState *)cpu_env)->eabi) {
struct target_eabi_stat64 *target_st;
@@ -6381,7 +6381,8 @@ abi_long do_syscall(void *cpu_env, int num, abi_long arg1,
#endif
#ifdef TARGET_NR_mmap
case TARGET_NR_mmap:
-#if (defined(TARGET_I386) && defined(TARGET_ABI32)) || defined(TARGET_ARM) || \
+#if (defined(TARGET_I386) && defined(TARGET_ABI32)) || \
+ (defined(TARGET_ARM) && defined(TARGET_ABI32)) || \
defined(TARGET_M68K) || defined(TARGET_CRIS) || defined(TARGET_MICROBLAZE) \
|| defined(TARGET_S390X)
{
diff --git a/linux-user/syscall_defs.h b/linux-user/syscall_defs.h
index 086fbff..2ebe356 100644
--- a/linux-user/syscall_defs.h
+++ b/linux-user/syscall_defs.h
@@ -1137,7 +1137,8 @@ struct target_winsize {
#define TARGET_MAP_UNINITIALIZED 0x4000000 /* for anonymous mmap, memory could be uninitialized */
#endif
-#if (defined(TARGET_I386) && defined(TARGET_ABI32)) || defined(TARGET_ARM) \
+#if (defined(TARGET_I386) && defined(TARGET_ABI32)) \
+ || (defined(TARGET_ARM) && defined(TARGET_ABI32)) \
|| defined(TARGET_CRIS) || defined(TARGET_UNICORE32)
struct target_stat {
unsigned short st_dev;
@@ -1835,6 +1836,28 @@ struct target_stat {
abi_long st_blocks;
abi_ulong __unused[3];
};
+#elif defined(TARGET_AARCH64)
+struct target_stat {
+ abi_ulong st_dev;
+ abi_ulong st_ino;
+ unsigned int st_mode;
+ unsigned int st_nlink;
+ unsigned int st_uid;
+ unsigned int st_gid;
+ abi_ulong st_rdev;
+ abi_ulong _pad1;
+ abi_long st_size;
+ int st_blksize;
+ int __pad2;
+ abi_long st_blocks;
+ abi_long target_st_atime;
+ abi_ulong target_st_atime_nsec;
+ abi_long target_st_mtime;
+ abi_ulong target_st_mtime_nsec;
+ abi_long target_st_ctime;
+ abi_ulong target_st_ctime_nsec;
+ unsigned int __unused[2];
+};
#elif defined(TARGET_OPENRISC)
/* These are the asm-generic versions of the stat and stat64 structures */
@@ -1943,7 +1966,8 @@ struct target_statfs64 {
uint32_t f_spare[6];
};
#elif (defined(TARGET_PPC64) || defined(TARGET_X86_64) || \
- defined(TARGET_SPARC64)) && !defined(TARGET_ABI32)
+ defined(TARGET_SPARC64) || defined(TARGET_AARCH64)) && \
+ !defined(TARGET_ABI32)
struct target_statfs {
abi_long f_type;
abi_long f_bsize;
--
1.7.9.5
next prev parent reply other threads:[~2013-09-10 18:52 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-10 18:51 [Qemu-devel] [PULL 00/28] target-arm queue Peter Maydell
2013-09-10 18:51 ` [Qemu-devel] [PULL 01/28] target-arm: Make '-cpu any' available in linux-user mode only Peter Maydell
2013-09-10 18:51 ` [Qemu-devel] [PULL 02/28] target-arm: Use sextract32() in branch decode Peter Maydell
2013-09-10 18:51 ` [Qemu-devel] [PULL 03/28] target-arm: Avoid "1 << 31" undefined behaviour Peter Maydell
2013-09-10 18:51 ` [Qemu-devel] [PULL 04/28] target-arm: fix ARMv7M stack alignment on reset Peter Maydell
2013-09-10 18:51 ` [Qemu-devel] [PULL 05/28] target-arm: Implement qmp query-cpu-definitions Peter Maydell
2013-09-10 18:52 ` [Qemu-devel] [PULL 06/28] pl110: Clarify comment about PL110 ID on VersatilePB Peter Maydell
2013-09-10 18:52 ` [Qemu-devel] [PULL 07/28] abitypes.h: Remove incorrect ARM ABI_LLONG_ALIGNMENT Peter Maydell
2013-09-10 18:52 ` [Qemu-devel] [PULL 08/28] target-arm: Abstract out load/store from a vaddr in AArch32 Peter Maydell
2013-09-10 18:52 ` [Qemu-devel] [PULL 09/28] target-arm: Extract the disas struct to a header file Peter Maydell
2013-09-10 18:52 ` [Qemu-devel] [PULL 10/28] target-arm: Export cpu_env Peter Maydell
2013-09-10 18:52 ` [Qemu-devel] [PULL 11/28] target-arm: Fix target_ulong/uint32_t confusions Peter Maydell
2013-09-10 18:52 ` [Qemu-devel] [PULL 12/28] target-arm: Pass DisasContext* to gen_set_pc_im() Peter Maydell
2013-09-10 18:52 ` [Qemu-devel] [PULL 13/28] target-arm: Add new AArch64CPUInfo base class and subclasses Peter Maydell
2013-09-10 18:52 ` [Qemu-devel] [PULL 14/28] target-arm: Disable 32 bit CPUs in 64 bit linux-user builds Peter Maydell
2013-09-10 18:52 ` [Qemu-devel] [PULL 15/28] target-arm: Prepare translation for AArch64 code Peter Maydell
2013-09-10 18:52 ` [Qemu-devel] [PULL 16/28] target-arm: Add AArch64 translation stub Peter Maydell
2013-09-10 18:52 ` [Qemu-devel] [PULL 17/28] target-arm: Add AArch64 gdbstub support Peter Maydell
2013-09-10 18:52 ` [Qemu-devel] [PULL 18/28] linux-user: Don't treat AArch64 cpu names specially Peter Maydell
2013-09-10 18:52 ` [Qemu-devel] [PULL 19/28] linux-user: Add cpu loop for AArch64 Peter Maydell
2013-09-10 18:52 ` [Qemu-devel] [PULL 20/28] linux-user: Add syscall number definitions " Peter Maydell
2013-09-10 18:52 ` Peter Maydell [this message]
2013-09-10 18:52 ` [Qemu-devel] [PULL 22/28] linux-user: Add signal handling " Peter Maydell
2013-09-10 18:52 ` [Qemu-devel] [PULL 23/28] linux-user: Make sure NWFPE code is 32 bit ARM only Peter Maydell
2013-09-10 18:52 ` [Qemu-devel] [PULL 24/28] linux-user: Implement cpu_set_tls() and cpu_clone_regs() for AArch64 Peter Maydell
2013-09-10 18:52 ` [Qemu-devel] [PULL 25/28] linux-user: Add AArch64 termbits.h definitions Peter Maydell
2013-09-10 18:52 ` [Qemu-devel] [PULL 26/28] linux-user: Allow targets to specify a minimum uname release Peter Maydell
2013-09-10 18:52 ` [Qemu-devel] [PULL 27/28] linux-user: Add AArch64 support Peter Maydell
2013-09-10 18:52 ` [Qemu-devel] [PULL 28/28] configure: Add handling code for AArch64 targets Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1378839142-7726-22-git-send-email-peter.maydell@linaro.org \
--to=peter.maydell@linaro.org \
--cc=anthony@codemonkey.ws \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).