From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:32834) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dINDL-0005AD-P5 for qemu-devel@nongnu.org; Tue, 06 Jun 2017 18:44:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dINDI-0007SZ-Ml for qemu-devel@nongnu.org; Tue, 06 Jun 2017 18:44:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35352) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dINDI-0007S0-Gt for qemu-devel@nongnu.org; Tue, 06 Jun 2017 18:44:36 -0400 Date: Tue, 6 Jun 2017 18:44:31 -0400 (EDT) From: Paolo Bonzini Message-ID: <1378843477.6503332.1496789071735.JavaMail.zimbra@redhat.com> In-Reply-To: <87a85ljdhn.fsf@dusky.pond.sub.org> References: <20170605085254.16485-1-sf@sfritsch.de> <39506179-0abd-5bba-89a2-fe89e6f3a167@redhat.com> <87a85ljdhn.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] Add chardev-send-break monitor command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: Eric Blake , Stefan Fritsch , qemu-devel@nongnu.org, =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , "Dr. David Alan Gilbert" > >> Is there an obvious test that we can enhance to add coverage of the new > >> QMP command? > > > > You could have a new test covering hw/char/serial.c, but I wouldn't let > > that hold the patch. > > Holding patches is pretty much the only leverage I have to get tests for > new stuff :) > > Asking for tests that cover all of serial.c wouldn't be fair. But I am > asking for basic test coverage of new QMP commands. I agree, on the other hand it's not exactly a comparable area. I am planning to write a serial qtest for migration as well (which is more complex than this QMP command) so I might as well write the test for this new QMP command myself to get my feet wet... Paolo