From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46542) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VJfMa-0001wC-J0 for qemu-devel@nongnu.org; Wed, 11 Sep 2013 04:01:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VJfMU-0005el-8N for qemu-devel@nongnu.org; Wed, 11 Sep 2013 04:01:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39662) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VJfMU-0005ed-1a for qemu-devel@nongnu.org; Wed, 11 Sep 2013 04:01:18 -0400 Message-ID: <1378886460.15290.4.camel@nilsson.home.kraxel.org> From: Gerd Hoffmann In-Reply-To: <52301EBD.5070209@redhat.com> References: <1378877909-28518-1-git-send-email-famz@redhat.com> <1378877909-28518-6-git-send-email-famz@redhat.com> <52301B4E.7000308@redhat.com> <52301EBD.5070209@redhat.com> Content-Type: text/plain; charset="UTF-8" Date: Wed, 11 Sep 2013 10:01:00 +0200 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH v5 5/6] configure: introduce --enable-modules List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: peter.maydell@linaro.org, Fam Zheng , mjt@tls.msk.ru, qemu-devel@nongnu.org, stefanha@redhat.com, vilanova@ac.upc.edu, rth@twiddle.net On Mi, 2013-09-11 at 09:41 +0200, Paolo Bonzini wrote: > Il 11/09/2013 09:27, Paolo Bonzini ha scritto: > > > > There are a couple of things that can be improved still (I don't like > > obj-save-y for example), but things are taking shape and all of this > > looks like something that can be fixed on top. If you look at > > converting more parts to modules (e.g. rbd or spice), you can drop that > > RFC! :) > > Talking about spice, a question for Gerd. > > With Fam's work to enable shared modules, hw/display/qxl* would have to > be placed in a module as well because they depend on ui/spice-core.c. Yes. Can modules depend on modules? Or would we have to create a single, big spice module with core, qxl, audio, chardev etc? > Right now, modularization is limited to files that are built once for > all of QEMU, which is not the case for qxl. > > It looks like TARGET_PAGE_SIZE is the only reason why qxl is built > per-target, and in qxl_ram_set_dirty it should be enough to do > > qxl_set_dirty(&qxl->vga.vram, offset, offset + 1); > > Would it be fine to use a generic 4096 constant everywhere else? Yes. Maybe s/TARGET_PAGE_SIZE/QXL_PAGE_SIZE/ to make clear that qxl operates on 4k pages. cheers, Gerd