From: Gerd Hoffmann <kraxel@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Fam Zheng" <famz@redhat.com>, "Michael Tokarev" <mjt@tls.msk.ru>,
"QEMU Developers" <qemu-devel@nongnu.org>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Lluís Vilanova" <vilanova@ac.upc.edu>,
"Richard Henderson" <rth@twiddle.net>
Subject: Re: [Qemu-devel] [RFC PATCH v5 5/6] configure: introduce --enable-modules
Date: Wed, 11 Sep 2013 12:37:40 +0200 [thread overview]
Message-ID: <1378895860.15290.32.camel@nilsson.home.kraxel.org> (raw)
In-Reply-To: <CAFEAcA_YqqNzgb9g4k5fDQ-B1=G2X+RPHFw86QEw3QKuf=Rqbg@mail.gmail.com>
> > (3) rom->num_pages field. That one will change for arm. The linux
> > kernel qxl kms driver seems not to care at all. Not surprising,
> > it is more convenient to use the offsets in the rom to figure how
> > the qxl memory layout looks like.
>
> Note that the ARM Linux *kernel* will (probably) be using 4K pages
> anyway. It's just that QEMU's TARGET_PAGE_SIZE means "smallest
> page size this CPU family could possibly support", which for ARM
> is 1K, even if 99.9% of guests won't use 1K pages. This is one
> of the reasons it's not very useful for devices -- it's almost just
> an internal implementation detail of QEMU's TLB/memory system.
>
> What is the num_pages field supposed to mean, given that
> "page size" isn't a well defined platform independent value
> (for hardware or for QEMU)?
It's 4k on x86 and not really defined on !x86 (with the !x86 installed
base being pretty close to zero).
I think we should just define it to be 4k everywhere.
cheers,
Gerd
next prev parent reply other threads:[~2013-09-11 10:38 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-11 5:38 [Qemu-devel] [RFC PATCH v5 0/6] Shared Library Module Support Fam Zheng
2013-09-11 5:38 ` [Qemu-devel] [RFC PATCH v5 1/6] make.rule: fix $(obj) to a real relative path Fam Zheng
2013-09-11 6:30 ` Paolo Bonzini
2013-09-11 7:05 ` Fam Zheng
2013-09-11 5:38 ` [Qemu-devel] [RFC PATCH v5 2/6] rule.mak: allow per object cflags and libs Fam Zheng
2013-09-11 5:38 ` [Qemu-devel] [RFC PATCH v5 3/6] Makefile: introduce common-obj-m and block-obj-m for DSO Fam Zheng
2013-09-11 5:38 ` [Qemu-devel] [RFC PATCH v5 4/6] module: implement module loading function Fam Zheng
2013-09-11 7:36 ` Paolo Bonzini
2013-09-11 14:10 ` Alex Bligh
2013-09-11 14:32 ` Paolo Bonzini
2013-09-11 15:06 ` Richard Henderson
2013-09-11 15:23 ` Alex Bligh
2013-09-11 15:43 ` Richard Henderson
2013-09-11 14:24 ` Peter Maydell
2013-09-12 3:12 ` Fam Zheng
2013-09-11 5:38 ` [Qemu-devel] [RFC PATCH v5 5/6] configure: introduce --enable-modules Fam Zheng
2013-09-11 7:27 ` Paolo Bonzini
2013-09-11 7:41 ` Paolo Bonzini
2013-09-11 8:01 ` Gerd Hoffmann
2013-09-11 8:17 ` Fam Zheng
2013-09-11 8:20 ` Peter Maydell
2013-09-11 8:56 ` Gerd Hoffmann
2013-09-11 10:03 ` Peter Maydell
2013-09-11 10:37 ` Gerd Hoffmann [this message]
2013-09-11 10:58 ` Peter Maydell
2013-09-11 8:35 ` Fam Zheng
2013-09-11 8:47 ` Paolo Bonzini
2013-09-11 5:38 ` [Qemu-devel] [RFC PATCH v5 6/6] block: build qed and curl as shared library Fam Zheng
2013-09-11 7:28 ` Paolo Bonzini
2013-09-11 7:36 ` Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1378895860.15290.32.camel@nilsson.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=famz@redhat.com \
--cc=mjt@tls.msk.ru \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=stefanha@redhat.com \
--cc=vilanova@ac.upc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).