From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, famz@redhat.com, Gerd Hoffmann <kraxel@redhat.com>
Subject: [Qemu-devel] [PATCH 3/4] qxl: simplify page dirtying
Date: Wed, 11 Sep 2013 13:33:39 +0200 [thread overview]
Message-ID: <1378899220-7631-3-git-send-email-kraxel@redhat.com> (raw)
In-Reply-To: <1378899220-7631-1-git-send-email-kraxel@redhat.com>
No need to do target page size calculations here,
memory_region_set_dirty will care for us.
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
hw/display/qxl.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/hw/display/qxl.c b/hw/display/qxl.c
index bcbf97a..ee2db0d 100644
--- a/hw/display/qxl.c
+++ b/hw/display/qxl.c
@@ -414,9 +414,8 @@ static void qxl_ram_set_dirty(PCIQXLDevice *qxl, void *ptr)
intptr_t offset;
offset = ptr - base;
- offset &= ~(TARGET_PAGE_SIZE-1);
assert(offset < qxl->vga.vram_size);
- qxl_set_dirty(&qxl->vga.vram, offset, offset + TARGET_PAGE_SIZE);
+ qxl_set_dirty(&qxl->vga.vram, offset, offset + 3);
}
/* can be called from spice server thread context */
--
1.8.3.1
next prev parent reply other threads:[~2013-09-11 11:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-11 11:33 [Qemu-devel] [PATCH 1/4] qxl: define qxl operating on 4k pages Gerd Hoffmann
2013-09-11 11:33 ` [Qemu-devel] [PATCH 2/4] qxl: simplify qxl_rom_size Gerd Hoffmann
2013-09-11 11:33 ` Gerd Hoffmann [this message]
2013-09-11 11:33 ` [Qemu-devel] [PATCH 4/4] qxl: compile only once Gerd Hoffmann
-- strict thread matches above, loose matches on Subject: below --
2013-09-19 9:38 [Qemu-devel] [PULL 0/4] spice patch queue Gerd Hoffmann
2013-09-19 9:38 ` [Qemu-devel] [PATCH 3/4] qxl: simplify page dirtying Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1378899220-7631-3-git-send-email-kraxel@redhat.com \
--to=kraxel@redhat.com \
--cc=famz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).