From: "Andreas Färber" <afaerber@suse.de>
To: qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Andreas Färber" <andreas.faerber@web.de>,
"Paul Brook" <paul@codesourcery.com>
Subject: [Qemu-devel] [PATCH v4 08/24] a9mpcore: Convert to QOM realize
Date: Wed, 11 Sep 2013 16:37:24 +0200 [thread overview]
Message-ID: <1378910260-7688-9-git-send-email-afaerber@suse.de> (raw)
In-Reply-To: <1378910260-7688-1-git-send-email-afaerber@suse.de>
From: Andreas Färber <andreas.faerber@web.de>
Signed-off-by: Andreas Färber <andreas.faerber@web.de>
---
hw/cpu/a9mpcore.c | 36 ++++++++++++++++++++++++++----------
1 file changed, 26 insertions(+), 10 deletions(-)
diff --git a/hw/cpu/a9mpcore.c b/hw/cpu/a9mpcore.c
index db3907e..a162ff0 100644
--- a/hw/cpu/a9mpcore.c
+++ b/hw/cpu/a9mpcore.c
@@ -59,38 +59,56 @@ static void a9mp_priv_initfn(Object *obj)
qdev_set_parent_bus(DEVICE(&s->wdt), sysbus_get_default());
}
-static int a9mp_priv_init(SysBusDevice *dev)
+static void a9mp_priv_realize(DeviceState *dev, Error **errp)
{
+ SysBusDevice *sbd = SYS_BUS_DEVICE(dev);
A9MPPrivState *s = A9MPCORE_PRIV(dev);
DeviceState *gicdev, *scudev, *mptimerdev, *wdtdev;
SysBusDevice *timerbusdev, *wdtbusdev, *gicbusdev, *scubusdev;
+ Error *err = NULL;
int i;
gicdev = DEVICE(&s->gic);
qdev_prop_set_uint32(gicdev, "num-cpu", s->num_cpu);
qdev_prop_set_uint32(gicdev, "num-irq", s->num_irq);
- qdev_init_nofail(gicdev);
+ object_property_set_bool(OBJECT(&s->gic), true, "realized", &err);
+ if (err != NULL) {
+ error_propagate(errp, err);
+ return;
+ }
gicbusdev = SYS_BUS_DEVICE(&s->gic);
/* Pass through outbound IRQ lines from the GIC */
- sysbus_pass_irq(dev, gicbusdev);
+ sysbus_pass_irq(sbd, gicbusdev);
/* Pass through inbound GPIO lines to the GIC */
- qdev_init_gpio_in(DEVICE(dev), a9mp_priv_set_irq, s->num_irq - 32);
+ qdev_init_gpio_in(dev, a9mp_priv_set_irq, s->num_irq - 32);
scudev = DEVICE(&s->scu);
qdev_prop_set_uint32(scudev, "num-cpu", s->num_cpu);
- qdev_init_nofail(scudev);
+ object_property_set_bool(OBJECT(&s->scu), true, "realized", &err);
+ if (err != NULL) {
+ error_propagate(errp, err);
+ return;
+ }
scubusdev = SYS_BUS_DEVICE(&s->scu);
mptimerdev = DEVICE(&s->mptimer);
qdev_prop_set_uint32(mptimerdev, "num-cpu", s->num_cpu);
- qdev_init_nofail(mptimerdev);
+ object_property_set_bool(OBJECT(&s->mptimer), true, "realized", &err);
+ if (err != NULL) {
+ error_propagate(errp, err);
+ return;
+ }
timerbusdev = SYS_BUS_DEVICE(&s->mptimer);
wdtdev = DEVICE(&s->wdt);
qdev_prop_set_uint32(wdtdev, "num-cpu", s->num_cpu);
- qdev_init_nofail(wdtdev);
+ object_property_set_bool(OBJECT(&s->wdt), true, "realized", &err);
+ if (err != NULL) {
+ error_propagate(errp, err);
+ return;
+ }
wdtbusdev = SYS_BUS_DEVICE(&s->wdt);
/* Memory map (addresses are offsets from PERIPHBASE):
@@ -129,7 +147,6 @@ static int a9mp_priv_init(SysBusDevice *dev)
sysbus_connect_irq(wdtbusdev, i,
qdev_get_gpio_in(gicdev, ppibase + 30));
}
- return 0;
}
static Property a9mp_priv_properties[] = {
@@ -147,9 +164,8 @@ static Property a9mp_priv_properties[] = {
static void a9mp_priv_class_init(ObjectClass *klass, void *data)
{
DeviceClass *dc = DEVICE_CLASS(klass);
- SysBusDeviceClass *k = SYS_BUS_DEVICE_CLASS(klass);
- k->init = a9mp_priv_init;
+ dc->realize = a9mp_priv_realize;
dc->props = a9mp_priv_properties;
}
--
1.8.1.4
next prev parent reply other threads:[~2013-09-11 14:38 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-11 14:37 [Qemu-devel] [PATCH v4 00/24] arm: ARM11MPCore+A9MPCore+A15MPCore QOM'ification Andreas Färber
2013-09-11 14:37 ` [Qemu-devel] [PATCH v4 01/24] a9mpcore: Split off instance_init Andreas Färber
2013-09-11 14:37 ` [Qemu-devel] [PATCH v4 02/24] arm_gic: Extract headers hw/intc/arm_gic{, _common}.h Andreas Färber
2013-09-11 14:37 ` [Qemu-devel] [PATCH v4 03/24] a9mpcore: Embed GICState Andreas Färber
2013-09-11 14:37 ` [Qemu-devel] [PATCH v4 04/24] a9scu: QOM cleanups Andreas Färber
2013-09-11 14:37 ` [Qemu-devel] [PATCH v4 05/24] a9mpcore: Embed A9SCUState Andreas Färber
2013-09-11 14:37 ` [Qemu-devel] [PATCH v4 06/24] arm_mptimer: Convert to QOM realize Andreas Färber
2013-09-11 14:37 ` [Qemu-devel] [PATCH v4 07/24] a9mpcore: Embed ARMMPTimerState Andreas Färber
2013-09-11 14:37 ` Andreas Färber [this message]
2013-09-11 14:37 ` [Qemu-devel] [PATCH v4 09/24] a9mpcore: Prepare for QOM embedding Andreas Färber
2013-09-11 14:37 ` [Qemu-devel] [PATCH v4 10/24] a15mpcore: Split off instance_init Andreas Färber
2013-09-11 14:37 ` [Qemu-devel] [PATCH v4 11/24] a15mpcore: Embed GICState Andreas Färber
2013-09-11 14:37 ` [Qemu-devel] [PATCH v4 12/24] a15mpcore: Convert to QOM realize Andreas Färber
2013-09-11 14:37 ` [Qemu-devel] [PATCH v4 13/24] a15mpcore: Prepare for QOM embedding Andreas Färber
2013-09-11 14:37 ` [Qemu-devel] [PATCH v4 14/24] a9scu: Build only once Andreas Färber
2013-09-11 14:37 ` [Qemu-devel] [PATCH v4 15/24] arm11mpcore: Fix typo in MemoryRegion name Andreas Färber
2013-09-11 14:37 ` [Qemu-devel] [PATCH v4 16/24] arm11mpcore: Drop unused fields Andreas Färber
2013-09-11 14:37 ` [Qemu-devel] [PATCH v4 17/24] arm11mpcore: Create container MemoryRegion in instance_init Andreas Färber
2013-09-11 14:37 ` [Qemu-devel] [PATCH v4 18/24] arm11mpcore: Split off SCU device Andreas Färber
2013-09-11 14:37 ` [Qemu-devel] [PATCH v4 19/24] arm11mpcore: Convert ARM11MPCorePriveState to QOM realize Andreas Färber
2013-09-11 14:37 ` [Qemu-devel] [PATCH v4 20/24] realview_gic: Convert " Andreas Färber
2013-09-11 14:37 ` [Qemu-devel] [PATCH v4 21/24] realview_gic: Prepare for QOM embedding Andreas Färber
2013-09-11 14:37 ` [Qemu-devel] [PATCH v4 22/24] arm11mpcore: Convert mpcore_rirq_state to QOM realize Andreas Färber
2013-09-11 14:37 ` [Qemu-devel] [PATCH v4 23/24] arm11mpcore: Prepare for QOM embedding Andreas Färber
2013-09-11 14:37 ` [Qemu-devel] [PATCH v4 24/24] arm11mpcore: Split off RealView MPCore Andreas Färber
2013-09-13 15:33 ` Peter Maydell
2013-09-13 15:40 ` Andreas Färber
2013-09-13 15:38 ` [Qemu-devel] [PATCH v4 00/24] arm: ARM11MPCore+A9MPCore+A15MPCore QOM'ification Peter Maydell
2013-09-18 17:06 ` Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1378910260-7688-9-git-send-email-afaerber@suse.de \
--to=afaerber@suse.de \
--cc=andreas.faerber@web.de \
--cc=paul@codesourcery.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).