From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>,
"Andreas Färber" <andreas.faerber@web.de>,
"Fam Zheng" <famz@redhat.com>,
patches@linaro.org
Subject: [Qemu-devel] [PATCH] ui/Makefile.objs: delete unnecessary cocoa.o dependency
Date: Wed, 11 Sep 2013 17:49:57 +0100 [thread overview]
Message-ID: <1378918197-9036-1-git-send-email-peter.maydell@linaro.org> (raw)
Delete an unnecessary dependency for cocoa.o; we already have
a general rule that tells Make that we can build a .o file
from a .m source using an ObjC compiler, so this specific
rule is unnecessary. Further, it is using the dubious construct
"$(SRC_PATH)/$(obj)" to get at the source directory, which will
break when $(obj) is redefined as part of the preparation for
per-object library support.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
This needs to go in before Fam's patchset for modules
can be applied, either via a cocoa maintainer queue or via
-trivial or just as a first patch on the front of Fam's
patches if they would otherwise be being held up by this.
ui/Makefile.objs | 2 --
1 file changed, 2 deletions(-)
diff --git a/ui/Makefile.objs b/ui/Makefile.objs
index 6ddc0de..f33be47 100644
--- a/ui/Makefile.objs
+++ b/ui/Makefile.objs
@@ -17,6 +17,4 @@ common-obj-$(CONFIG_GTK) += gtk.o x_keymap.o
$(obj)/sdl.o $(obj)/sdl_zoom.o: QEMU_CFLAGS += $(SDL_CFLAGS)
-$(obj)/cocoa.o: $(SRC_PATH)/$(obj)/cocoa.m
-
$(obj)/gtk.o: QEMU_CFLAGS += $(GTK_CFLAGS) $(VTE_CFLAGS)
--
1.7.11.4
next reply other threads:[~2013-09-11 16:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-11 16:49 Peter Maydell [this message]
2013-09-12 1:23 ` [Qemu-devel] [PATCH] ui/Makefile.objs: delete unnecessary cocoa.o dependency Fam Zheng
2013-09-12 14:14 ` Andreas Färber
2013-09-12 14:20 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1378918197-9036-1-git-send-email-peter.maydell@linaro.org \
--to=peter.maydell@linaro.org \
--cc=andreas.faerber@web.de \
--cc=famz@redhat.com \
--cc=patches@linaro.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).