From: Fam Zheng <famz@redhat.com>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, famz@redhat.com, mjt@tls.msk.ru,
alex@alex.org.uk, pbonzini@redhat.com, vilanova@ac.upc.edu,
rth@twiddle.net
Subject: [Qemu-devel] [PATCH v7 0/8] Shared Library Module Support
Date: Thu, 12 Sep 2013 15:04:51 +0800 [thread overview]
Message-ID: <1378969499-15066-1-git-send-email-famz@redhat.com> (raw)
This series implements feature of shared object building as described in:
http://wiki.qemu.org/Features/Modules
The main idea behind modules is to isolate dependencies on third party
libraries from qemu executables, such as libglusterfs or librbd, so that the
end users can install core qemu package with fewer dependencies. And only for
those who want to use particular modules, need they install qemu-foo
sub-package, which in turn requires libbar and libbiz packages.
It's implemented in three steps:
1. The first patches fix current build system to correctly handle nested
variables and object specific options:
[01/08] ui/Makefile.objs: delete unnecessary cocoa.o dependency
[02/08] make.rule: fix $(obj) to a real relative path
[03/08] rule.mak: allow per object cflags and libs
2. The Makefile changes adds necessary options and rules to build DSO objects:
[04/08] build-sys: introduce common-obj-m and block-obj-m for DSO
3. The next patch adds framework to load modules from installed directory:
[05/08] module: implement module loading function
A few more changes are following to complete it:
[06/08] Makefile: install modules with "make install"
[07/08] .gitignore: ignore module related files (dll, so, mo)
In the end of series, the block drivers are converted:
[08/08] block: convert block drivers linked with libs to modules
v7: While the discussion on module path and loading restriction goes on, more
input and revisions are apparently necessary to achieve a proper design.
However I'd like to send this revision for building system fixes spotted from
reviewers, to make it easier for early testing:
[01] Add Peter's patch for ui/Makefile.objs. (Peter)
[02] Move nested vars prefixing to immediately after unnest-vars-1 (Paolo)
Fix order of libcacard/Makefile and unnest-vars in Makefile. (Daniel)
[03] Fix link command if no libtool. (Peter)
[04] Squash in "--enable-modules". (Paolo)
Fix a missing comma in no dso building.
[05] Don't load modules in *-user. (Peter)
#ifdef out module loading code if no --enable-modules. (Daniel)
v6: Dropping RFC.
[01] Move addprefix to unnest-vars.
[01] Drop unnest-vars in tests/Makefile.
[03] Move "all: modules" to Makefile.
[03] Add empty modules: in rules.mak, for clarity.
[03] .mo is no longer storing object list, just an empty file now. In
expand-objs, objects are extracted with $foo.mo-objs). another reason for
this is for makefile.target, objects in .mo file would be prefixed with
../, so generated two times in one "make all", which always outdates the
link target.
[04] Use CONFIG_MODDIR instead of CONFIG_PREFIX for module searching.
[06] Added make install.
[07] New.
[08] Drop qed changes, added iscsi, ssh, rbd and gluster as modules.
v5: Keep foo.mo-objs idea for module objects.
Unnest block-obj-m and common-obj-m in Makefile.target.
Move add-modules to unnest-vars to be reused in Makefile.target.
Use /dev/null to replace realpath for expand-objs.
v4: Added --enable-modules in the end of series.
Make nested-vars and obj-base as arguemnts to unnest-vars.
Take Paolo's idea in comments for v2 and switch back module objects syntax
to:
$(obj)/foo.mo : $(addprefix $(obj)/, bar.o biz.o qux.o)
because this needs less duplication among Makefiles.
Fam Zheng (7):
make.rule: fix $(obj) to a real relative path
rule.mak: allow per object cflags and libs
build-sys: introduce common-obj-m and block-obj-m for DSO
module: implement module loading function
Makefile: install modules with "make install"
.gitignore: ignore module related files (dll, so, mo)
block: convert block drivers linked with libs to modules
Peter Maydell (1):
ui/Makefile.objs: delete unnecessary cocoa.o dependency
.gitignore | 3 ++
Makefile | 28 ++++++++++++++++++-
Makefile.objs | 18 ++----------
Makefile.target | 21 +++++++++++---
block.c | 1 +
block/Makefile.objs | 11 +++++++-
configure | 74 ++++++++++++++++++++++++++++++++-----------------
include/qemu/module.h | 9 ++++++
rules.mak | 77 ++++++++++++++++++++++++++++++++++++++++++---------
scripts/create_config | 10 +++++++
ui/Makefile.objs | 2 --
util/module.c | 55 ++++++++++++++++++++++++++++++++++++
vl.c | 2 ++
13 files changed, 249 insertions(+), 62 deletions(-)
--
1.8.3.1
next reply other threads:[~2013-09-12 7:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-12 7:04 Fam Zheng [this message]
2013-09-12 7:04 ` [Qemu-devel] [PATCH v7 1/8] ui/Makefile.objs: delete unnecessary cocoa.o dependency Fam Zheng
2013-09-12 7:04 ` [Qemu-devel] [PATCH v7 2/8] make.rule: fix $(obj) to a real relative path Fam Zheng
2013-09-12 7:04 ` [Qemu-devel] [PATCH v7 3/8] rule.mak: allow per object cflags and libs Fam Zheng
2013-09-12 7:04 ` [Qemu-devel] [PATCH v7 4/8] build-sys: introduce common-obj-m and block-obj-m for DSO Fam Zheng
2013-09-12 7:04 ` [Qemu-devel] [PATCH v7 5/8] module: implement module loading function Fam Zheng
2013-09-12 14:08 ` Daniel P. Berrange
2013-09-13 1:29 ` Fam Zheng
2013-09-12 7:04 ` [Qemu-devel] [PATCH v7 6/8] Makefile: install modules with "make install" Fam Zheng
2013-09-12 14:06 ` Daniel P. Berrange
2013-09-13 1:27 ` Fam Zheng
2013-09-12 7:04 ` [Qemu-devel] [PATCH v7 7/8] .gitignore: ignore module related files (dll, so, mo) Fam Zheng
2013-09-12 7:04 ` [Qemu-devel] [PATCH v7 8/8] block: convert block drivers linked with libs to modules Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1378969499-15066-1-git-send-email-famz@redhat.com \
--to=famz@redhat.com \
--cc=alex@alex.org.uk \
--cc=mjt@tls.msk.ru \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=vilanova@ac.upc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).