From: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, pbonzini@redhat.com, anthony@codemonkey.ws,
stefanha@redhat.com, Wenchao Xia <xiawenc@linux.vnet.ibm.com>
Subject: [Qemu-devel] [RFC PATCH 8/8] stubs: remove mon-protocol-event.o in stub obj
Date: Thu, 12 Sep 2013 17:15:12 +0800 [thread overview]
Message-ID: <1378977312-17696-9-git-send-email-xiawenc@linux.vnet.ibm.com> (raw)
In-Reply-To: <1378977312-17696-1-git-send-email-xiawenc@linux.vnet.ibm.com>
Now block layer do not use this symbol now, so qemg-img, qemu-io
and qemu-nbd do not link with this file any more. The test program
tests/test-qdev-global-props still need it, so add this obj in
rule of test/Makefile, and keeps the c file now.
Signed-off-by: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
---
stubs/Makefile.objs | 1 -
tests/Makefile | 3 ++-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/stubs/Makefile.objs b/stubs/Makefile.objs
index f306cba..6fe1e3f 100644
--- a/stubs/Makefile.objs
+++ b/stubs/Makefile.objs
@@ -15,7 +15,6 @@ stub-obj-y += migr-blocker.o
stub-obj-y += mon-is-qmp.o
stub-obj-y += mon-printf.o
stub-obj-y += mon-print-filename.o
-stub-obj-y += mon-protocol-event.o
stub-obj-y += mon-set-error.o
stub-obj-y += pci-drive-hot-add.o
stub-obj-y += reset.o
diff --git a/tests/Makefile b/tests/Makefile
index c13fefc..7d3ee3b 100644
--- a/tests/Makefile
+++ b/tests/Makefile
@@ -134,7 +134,8 @@ tests/test-qdev-global-props$(EXESUF): tests/test-qdev-global-props.o \
hw/core/irq.o \
qom/object.o qom/container.o qom/qom-qobject.o \
$(test-qapi-obj-y) \
- libqemuutil.a libqemustub.a
+ libqemuutil.a libqemustub.a \
+ stubs/mon-protocol-event.o
tests/test-qapi-types.c tests/test-qapi-types.h :\
$(SRC_PATH)/tests/qapi-schema/qapi-schema-test.json $(SRC_PATH)/scripts/qapi-types.py
--
1.7.1
next prev parent reply other threads:[~2013-09-12 9:15 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-12 9:15 [Qemu-devel] [RFC PATCH 0/8] Remove stub mon-protocol-event for block Wenchao Xia
2013-09-12 9:15 ` [Qemu-devel] [RFC PATCH 1/8] block: use type MonitorEvent directly Wenchao Xia
2013-09-23 15:53 ` Eric Blake
2013-09-12 9:15 ` [Qemu-devel] [RFC PATCH 2/8] block: do not include monitor.h in block.c Wenchao Xia
2013-09-23 15:53 ` Eric Blake
2013-09-12 9:15 ` [Qemu-devel] [RFC PATCH 3/8] qapi: move MonitorEvent define Wenchao Xia
2013-09-23 15:55 ` Eric Blake
2013-09-24 14:05 ` Wenchao Xia
2013-09-12 9:15 ` [Qemu-devel] [RFC PATCH 4/8] qapi: rename MonitorEvent to QEvent Wenchao Xia
2013-09-23 15:56 ` Eric Blake
2013-09-12 9:15 ` [Qemu-devel] [RFC PATCH 5/8] block: add a callback layer for common functions Wenchao Xia
2013-09-12 9:15 ` [Qemu-devel] [RFC PATCH 6/8] block: replace monitor_protocol_event() with callback Wenchao Xia
2013-09-12 9:15 ` [Qemu-devel] [RFC PATCH 7/8] block: do not include monitor.h Wenchao Xia
2013-09-12 9:15 ` Wenchao Xia [this message]
2013-09-12 9:31 ` [Qemu-devel] [RFC PATCH 0/8] Remove stub mon-protocol-event for block Paolo Bonzini
2013-09-12 12:08 ` Kevin Wolf
2013-09-12 14:43 ` Paolo Bonzini
2013-09-12 12:44 ` Markus Armbruster
2013-09-16 4:59 ` Wenchao Xia
2013-09-16 10:02 ` Paolo Bonzini
2013-09-17 2:27 ` Wenchao Xia
2013-09-23 19:06 ` Wenchao Xia
2013-09-23 7:52 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1378977312-17696-9-git-send-email-xiawenc@linux.vnet.ibm.com \
--to=xiawenc@linux.vnet.ibm.com \
--cc=anthony@codemonkey.ws \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).