From: Fam Zheng <famz@redhat.com>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, famz@redhat.com, mjt@tls.msk.ru,
alex@alex.org.uk, pbonzini@redhat.com, vilanova@ac.upc.edu,
rth@twiddle.net
Subject: [Qemu-devel] [PATCH v9 1/8] ui/Makefile.objs: delete unnecessary cocoa.o dependency
Date: Fri, 13 Sep 2013 17:59:09 +0800 [thread overview]
Message-ID: <1379066356-14986-2-git-send-email-famz@redhat.com> (raw)
In-Reply-To: <1379066356-14986-1-git-send-email-famz@redhat.com>
From: Peter Maydell <peter.maydell@linaro.org>
Delete an unnecessary dependency for cocoa.o; we already have
a general rule that tells Make that we can build a .o file
from a .m source using an ObjC compiler, so this specific
rule is unnecessary. Further, it is using the dubious construct
"$(SRC_PATH)/$(obj)" to get at the source directory, which will
break when $(obj) is redefined as part of the preparation for
per-object library support.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Fam Zheng <famz@redhat.com>
---
ui/Makefile.objs | 2 --
1 file changed, 2 deletions(-)
diff --git a/ui/Makefile.objs b/ui/Makefile.objs
index 6ddc0de..f33be47 100644
--- a/ui/Makefile.objs
+++ b/ui/Makefile.objs
@@ -17,6 +17,4 @@ common-obj-$(CONFIG_GTK) += gtk.o x_keymap.o
$(obj)/sdl.o $(obj)/sdl_zoom.o: QEMU_CFLAGS += $(SDL_CFLAGS)
-$(obj)/cocoa.o: $(SRC_PATH)/$(obj)/cocoa.m
-
$(obj)/gtk.o: QEMU_CFLAGS += $(GTK_CFLAGS) $(VTE_CFLAGS)
--
1.8.3.1
next prev parent reply other threads:[~2013-09-13 9:59 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-13 9:59 [Qemu-devel] [PATCH v9 0/8] Shared Library Module Support Fam Zheng
2013-09-13 9:59 ` Fam Zheng [this message]
2013-09-13 9:59 ` [Qemu-devel] [PATCH v9 2/8] make.rule: fix $(obj) to a real relative path Fam Zheng
2013-09-13 9:59 ` [Qemu-devel] [PATCH v9 3/8] rule.mak: allow per object cflags and libs Fam Zheng
2013-09-13 9:59 ` [Qemu-devel] [PATCH v9 4/8] build-sys: introduce common-obj-m and block-obj-m for DSO Fam Zheng
2013-09-13 9:59 ` [Qemu-devel] [PATCH v9 5/8] module: implement module loading Fam Zheng
2013-09-13 14:07 ` Daniel P. Berrange
2013-09-16 1:30 ` Fam Zheng
2013-09-13 14:52 ` Richard Henderson
2013-09-13 16:20 ` Michael Tokarev
2013-09-13 19:43 ` Richard Henderson
2013-09-16 1:41 ` Fam Zheng
2013-09-13 9:59 ` [Qemu-devel] [PATCH v9 6/8] Makefile: install modules with "make install" Fam Zheng
2013-09-13 9:59 ` [Qemu-devel] [PATCH v9 7/8] .gitignore: ignore module related files (dll, so, mo) Fam Zheng
2013-09-13 9:59 ` [Qemu-devel] [PATCH v9 8/8] block: convert block drivers linked with libs to modules Fam Zheng
2013-09-13 11:31 ` [Qemu-devel] [PATCH v9 0/8] Shared Library Module Support Peter Maydell
2013-09-16 1:32 ` Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1379066356-14986-2-git-send-email-famz@redhat.com \
--to=famz@redhat.com \
--cc=alex@alex.org.uk \
--cc=mjt@tls.msk.ru \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=vilanova@ac.upc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).