From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48567) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VKs6w-0000c7-Rn for qemu-devel@nongnu.org; Sat, 14 Sep 2013 11:50:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VKs6m-0004rE-Le for qemu-devel@nongnu.org; Sat, 14 Sep 2013 11:50:14 -0400 Received: from smtp2-g21.free.fr ([2a01:e0c:1:1599::11]:37490) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VKs6l-0004hh-GD for qemu-devel@nongnu.org; Sat, 14 Sep 2013 11:50:04 -0400 From: =?UTF-8?q?Herv=C3=A9=20Poussineau?= Date: Sat, 14 Sep 2013 17:51:06 +0200 Message-Id: <1379173870-10974-3-git-send-email-hpoussin@reactos.org> In-Reply-To: <1379173870-10974-1-git-send-email-hpoussin@reactos.org> References: <1379173870-10974-1-git-send-email-hpoussin@reactos.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PATCH v2 2/5] lsi: check ssid versus sdid only if ssid is valid List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Paolo Bonzini , =?UTF-8?q?Herv=C3=A9=20Poussineau?= This prevents some (invalid) error messages on console. Signed-off-by: Herv=C3=A9 Poussineau --- hw/scsi/lsi53c895a.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/scsi/lsi53c895a.c b/hw/scsi/lsi53c895a.c index ca01e86..764feaa 100644 --- a/hw/scsi/lsi53c895a.c +++ b/hw/scsi/lsi53c895a.c @@ -1705,8 +1705,9 @@ static void lsi_reg_writeb(LSIState *s, int offset,= uint8_t val) s->sxfer =3D val; break; case 0x06: /* SDID */ - if ((val & 0xf) !=3D (s->ssid & 0xf)) + if ((s->ssid & 0x80) && (val & 0xf) !=3D (s->ssid & 0xf)) { BADF("Destination ID does not match SSID\n"); + } s->sdid =3D val & 0xf; break; case 0x07: /* GPREG0 */ --=20 1.7.10.4