From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34533) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VKxo8-00018s-7O for qemu-devel@nongnu.org; Sat, 14 Sep 2013 17:55:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VKxo2-00042E-Cs for qemu-devel@nongnu.org; Sat, 14 Sep 2013 17:55:12 -0400 Received: from mail-pa0-x234.google.com ([2607:f8b0:400e:c03::234]:35011) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VKxo2-0003zt-55 for qemu-devel@nongnu.org; Sat, 14 Sep 2013 17:55:06 -0400 Received: by mail-pa0-f52.google.com with SMTP id kq13so3867862pab.25 for ; Sat, 14 Sep 2013 14:55:05 -0700 (PDT) Sender: Richard Henderson From: Richard Henderson Date: Sat, 14 Sep 2013 14:54:24 -0700 Message-Id: <1379195690-6509-8-git-send-email-rth@twiddle.net> In-Reply-To: <1379195690-6509-1-git-send-email-rth@twiddle.net> References: <1379195690-6509-1-git-send-email-rth@twiddle.net> Subject: [Qemu-devel] [PATCH v4 07/33] tcg-aarch64: Remove the shift_imm parameter from tcg_out_cmp List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, claudio.fontana@gmail.com It was unused. Let's not overcomplicate things before we need them. Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tcg/aarch64/tcg-target.c b/tcg/aarch64/tcg-target.c index be6d05a..cc56fe5 100644 --- a/tcg/aarch64/tcg-target.c +++ b/tcg/aarch64/tcg-target.c @@ -543,10 +543,10 @@ static inline void tcg_out_rotl(TCGContext *s, TCGType ext, } static inline void tcg_out_cmp(TCGContext *s, TCGType ext, TCGReg rn, - TCGReg rm, int shift_imm) + TCGReg rm) { /* Using CMP alias SUBS wzr, Wn, Wm */ - tcg_out_arith(s, INSN_SUBS, ext, TCG_REG_XZR, rn, rm, shift_imm); + tcg_out_arith(s, INSN_SUBS, ext, TCG_REG_XZR, rn, rm, 0); } static inline void tcg_out_cset(TCGContext *s, TCGType ext, @@ -920,7 +920,7 @@ static void tcg_out_tlb_read(TCGContext *s, TCGReg addr_reg, (is_read ? offsetof(CPUTLBEntry, addr_read) : offsetof(CPUTLBEntry, addr_write))); /* Perform the address comparison. */ - tcg_out_cmp(s, (TARGET_LONG_BITS == 64), TCG_REG_X0, TCG_REG_X3, 0); + tcg_out_cmp(s, (TARGET_LONG_BITS == 64), TCG_REG_X0, TCG_REG_X3); *label_ptr = s->code_ptr; /* If not equal, we jump to the slow path. */ tcg_out_goto_cond_noaddr(s, TCG_COND_NE); @@ -1259,13 +1259,13 @@ static void tcg_out_op(TCGContext *s, TCGOpcode opc, case INDEX_op_brcond_i64: case INDEX_op_brcond_i32: - tcg_out_cmp(s, ext, a0, a1, 0); + tcg_out_cmp(s, ext, a0, a1); tcg_out_goto_label_cond(s, a2, args[3]); break; case INDEX_op_setcond_i64: case INDEX_op_setcond_i32: - tcg_out_cmp(s, ext, a1, a2, 0); + tcg_out_cmp(s, ext, a1, a2); tcg_out_cset(s, 0, a0, args[3]); break; -- 1.8.3.1