From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48220) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VKzp0-0007YQ-Ve for qemu-devel@nongnu.org; Sat, 14 Sep 2013 20:04:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VKzov-00011V-4i for qemu-devel@nongnu.org; Sat, 14 Sep 2013 20:04:14 -0400 Received: from mail-pd0-x22e.google.com ([2607:f8b0:400e:c02::22e]:42882) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VKzou-00011L-TY for qemu-devel@nongnu.org; Sat, 14 Sep 2013 20:04:09 -0400 Received: by mail-pd0-f174.google.com with SMTP id y13so2677604pdi.5 for ; Sat, 14 Sep 2013 17:04:08 -0700 (PDT) Sender: Richard Henderson From: Richard Henderson Date: Sat, 14 Sep 2013 17:03:52 -0700 Message-Id: <1379203434-5680-7-git-send-email-rth@twiddle.net> In-Reply-To: <1379203434-5680-1-git-send-email-rth@twiddle.net> References: <1379203434-5680-1-git-send-email-rth@twiddle.net> Subject: [Qemu-devel] [PATCH 6/8] tcg: Put target helper data into an array. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, Richard Henderson , aurelien@aurel32.net, sw@weilnetz.de One call inside of a loop to tcg_register_helper instead of hundreds of sequential calls. Presumably more icache and branch prediction friendly; resulting binary size mostly unchanged on x86_64, as we're trading 32-bit rip-relative references in .text for full 64-bit pointers in .rodata. Signed-off-by: Richard Henderson --- include/exec/def-helper.h | 3 +-- tcg/tcg.c | 17 ++++++++++++++--- 2 files changed, 15 insertions(+), 5 deletions(-) diff --git a/include/exec/def-helper.h b/include/exec/def-helper.h index 022a9ce..73d51f9 100644 --- a/include/exec/def-helper.h +++ b/include/exec/def-helper.h @@ -240,8 +240,7 @@ static inline void glue(gen_helper_, name)(dh_retvar_decl(ret) \ #elif GEN_HELPER == 2 /* Register helpers. */ -#define DEF_HELPER_FLAGS_0(name, flags, ret) \ -tcg_register_helper(HELPER(name), #name); +#define DEF_HELPER_FLAGS_0(name, flags, ret) { HELPER(name), #name }, #define DEF_HELPER_FLAGS_1(name, flags, ret, t1) \ DEF_HELPER_FLAGS_0(name, flags, ret) diff --git a/tcg/tcg.c b/tcg/tcg.c index 59251c0..9ace8fc 100644 --- a/tcg/tcg.c +++ b/tcg/tcg.c @@ -256,9 +256,19 @@ void tcg_pool_reset(TCGContext *s) #include "helper.h" +typedef struct TCGHelperInfo { + void *func; + const char *name; +} TCGHelperInfo; + +static const TCGHelperInfo all_helpers[] = { +#define GEN_HELPER 2 +#include "helper.h" +}; + void tcg_context_init(TCGContext *s) { - int op, total_args, n; + int op, total_args, n, i; TCGOpDef *def; TCGArgConstraint *args_ct; int *sorted_args; @@ -288,8 +298,9 @@ void tcg_context_init(TCGContext *s) } /* Register helpers. */ -#define GEN_HELPER 2 -#include "helper.h" + for (i = 0; i < ARRAY_SIZE(all_helpers); ++i) { + tcg_register_helper(all_helpers[i].func, all_helpers[i].name); + } tcg_target_init(s); } -- 1.8.1.4