From: Marcel Apfelbaum <marcel.a@redhat.com>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, aliguori@us.ibm.com, mst@redhat.com,
jan.kiszka@siemens.com, pbonzini@redhat.com, afaerber@suse.de
Subject: [Qemu-devel] [PATCH v4 0/3] pci: implement upstream master abort protocol
Date: Sun, 15 Sep 2013 19:16:38 +0300 [thread overview]
Message-ID: <1379261801-16969-1-git-send-email-marcel.a@redhat.com> (raw)
PCI spec requires that a transaction that has not been claimed
by any PCI bus devices will be terminated by the initiator
with "master abort". For read transactions -1(FFFFFFFF) is returned and
writes are silently dropped.
Implementation:
- Allowed the MemoryRegion priority to be negative so a subregion will be
visible on all the addresses not covered by other container subregions.
- Added a memory region with negative priority that extends over all the
pci address space. This region catches all the accesses
to the unassigned pci addresses.
- The MemoryRegion's ops emulates the master abort scenario.
Note: The code handles only the reads/writes to pci address space
that are done by the cpu.
I am working on implementing the following on top of this series
- Implement upstream master abort
- Handling of RECEIVED MASTER ABORT BIT in Stastus register
Changes from v3:
- Addressed Peter Maydell comments
- Removed unnecessary changes to priority of MemoryListener
- Ensured that priority is now signed in all related places
- Added to memory docs explanation on signed priorities
- Addresses Michael S. Tsirkin comments
- Changed the name of the new Memory region to master_abort_mem
- Made master abort priority INT_MIN instead of -1
- Removed handling of RECEIVED MASTER ABORT BIT; it will be taken
care in a different series
Changes from v2:
- minor: changed nr of patches in the title
- minor: modified series list
Changes from v1:
- "pci-unassigned-mem" MemoryRegion resides now in PCIBus and not on
various Host Bridges
- "pci-unassgined-mem" does not have a ".valid.accept" field and
implements read write methods
Marcel Apfelbaum (3):
memory: allow MemoryRegion's priority field to accept negative values
docs/memory: Explictly state that MemoryRegion priority is signed
hw/pci: partially handle pci master abort
docs/memory.txt | 4 ++++
hw/core/sysbus.c | 4 ++--
hw/pci/pci.c | 27 +++++++++++++++++++++++++++
include/exec/memory.h | 4 ++--
include/hw/pci/pci_bus.h | 1 +
include/hw/sysbus.h | 2 +-
memory.c | 4 ++--
7 files changed, 39 insertions(+), 7 deletions(-)
--
1.8.3.1
next reply other threads:[~2013-09-15 16:16 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-15 16:16 Marcel Apfelbaum [this message]
2013-09-15 16:16 ` [Qemu-devel] [PATCH v4 1/3] memory: allow MemoryRegion's priority field to accept negative values Marcel Apfelbaum
2013-09-15 17:18 ` Michael S. Tsirkin
2013-09-15 17:25 ` Peter Maydell
2013-09-15 17:34 ` Peter Maydell
2013-09-15 16:16 ` [Qemu-devel] [PATCH v4 2/3] docs/memory: Explicitly state that MemoryRegion priority is signed Marcel Apfelbaum
2013-09-15 17:33 ` Peter Maydell
2013-09-15 16:16 ` [Qemu-devel] [PATCH v4 3/3] hw/pci: handle downstream pci master abort Marcel Apfelbaum
2013-09-15 17:30 ` Michael S. Tsirkin
2013-09-15 17:32 ` Peter Maydell
2013-09-15 18:32 ` Marcel Apfelbaum
2013-09-15 20:25 ` Michael S. Tsirkin
2013-09-15 20:40 ` Peter Maydell
2013-09-15 21:07 ` Michael S. Tsirkin
2013-09-15 21:41 ` Peter Maydell
2013-09-16 6:14 ` Michael S. Tsirkin
2013-09-16 6:57 ` Peter Maydell
2013-09-15 18:26 ` Marcel Apfelbaum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1379261801-16969-1-git-send-email-marcel.a@redhat.com \
--to=marcel.a@redhat.com \
--cc=afaerber@suse.de \
--cc=aliguori@us.ibm.com \
--cc=jan.kiszka@siemens.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).